Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-arrange import orders. #564

Merged
merged 10 commits into from Mar 5, 2020
Merged

Re-arrange import orders. #564

merged 10 commits into from Mar 5, 2020

Conversation

@vtomole
Copy link
Collaborator

vtomole commented Mar 2, 2020

No description provided.

vtomole added 2 commits Mar 2, 2020
@vtomole vtomole requested review from kevinsung and obriente Mar 2, 2020
@googlebot googlebot added the cla: yes label Mar 2, 2020
@vtomole

This comment has been minimized.

Copy link
Collaborator Author

vtomole commented Mar 2, 2020

The failing lines were not there on my local machine.

vtomole added 5 commits Mar 2, 2020
@vtomole

This comment has been minimized.

Copy link
Collaborator Author

vtomole commented Mar 5, 2020

Why

coverage/coveralls Expected — Waiting for status to be reported? Thought we removed it.

Copy link
Collaborator

kevinsung left a comment

I suspect that the coveralls check will remain on PRs that were opened before we removed it (?)

@kevinsung

This comment has been minimized.

Copy link
Collaborator

kevinsung commented Mar 5, 2020

I removed the coveralls check.

@vtomole vtomole requested a review from kevinsung Mar 5, 2020
@vtomole

This comment has been minimized.

Copy link
Collaborator Author

vtomole commented Mar 5, 2020

@kevinsung Please merge.

@kevinsung

This comment has been minimized.

Copy link
Collaborator

kevinsung commented Mar 5, 2020

@vtomole I think I gave you the access needed to merge yourself.

@kevinsung kevinsung merged commit e6494c2 into quantumlib:master Mar 5, 2020
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.