Move Rabi Oscillations Experiment from Cirq to ReCirq #292
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@mpharrigan @dstrain115 Requesting review by comment because I don't think I can through the github interface 👍 |
|
I'm hesitant to add a new top-level module for each little thing like this. Can we combine it with somewhere else? |
|
|
|
Can we put this code in |
|
Maybe we could add "tools/" ? |
|
Or adding it to benchmarks seems acceptable as well. |
|
Moved to |
| @@ -0,0 +1,488 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #8. v = hashlib.sha256(str(q).encode()).digest()[0] / 256
lol why are we doing this hashing? can't we just put a number
Reply via ReviewNB
There was a problem hiding this comment.
I'm not sure. Maybe the original author intended it to hide the actual value of
dstrain115
left a comment
dstrain115
left a comment
There was a problem hiding this comment.
This is fine with me, modulo one comment.
| "id": "b2TkL28AmBSQ" | ||
| }, | ||
| "source": [ | ||
| "## 3. The ReCirq experiment\n", |
There was a problem hiding this comment.
This still doesn't really explain this at all. I would consider linking to the wikipedia article and maybe explaining why we want to do this?
Rabi Oscillations have been moved per quantumlib/ReCirq#292. Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography) Also ran a formatter and cleared outputs from intro notebook Only merge with redirect cl/452988155
…tumlib#5448) Rabi Oscillations have been moved per quantumlib/ReCirq#292. Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography) Also ran a formatter and cleared outputs from intro notebook Only merge with redirect cl/452988155
…tumlib#5448) Rabi Oscillations have been moved per quantumlib/ReCirq#292. Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography) Also ran a formatter and cleared outputs from intro notebook Only merge with redirect cl/452988155
…tumlib#5448) Rabi Oscillations have been moved per quantumlib/ReCirq#292. Also update the intro notebook to not use now-moved recirq experiment (replaced with single_qubit_state_tomography) Also ran a formatter and cleared outputs from intro notebook Only merge with redirect cl/452988155
3 participants
This experiment has some code in cirq-core/cirq/experiments, along with a docs notebook. Both have been moved here, into recirq/rabi_oscillations and docs/rabi_oscillations respectively