Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tome Rater (PWP) #1

Closed
sangjunp4rk opened this issue Nov 3, 2018 · 1 comment
Closed

Tome Rater (PWP) #1

sangjunp4rk opened this issue Nov 3, 2018 · 1 comment

Comments

@sangjunp4rk
Copy link

Rubric Score

Criteria 1: Valid Python Code

  • Score Level: 4/4 Exceeds Expectations
  • Comment(s): No syntax errors. But great job writing all valid Python code without any errors or issues!

Criteria 2: Implementation of Project Requirements

  • Score Level: 3.5/4 Exceeds Expectations
  • Comment(s): You implemented the functions successfully. Next time please include your testing functions or scripts. It's good to get into the habit of not only running given tests but also your own tests to make sure everything is functioning correctly. You can either include this directly in your code or put it in another file that you use to test. The latter method is cleaner since you keep your code and tests separate.

Criteria 3: Software Architecture

  • Score Level: 4/4
  • Comment(s): Great job defining and naming classes and functions. Everything was written correctly and you simplified you code as much as possible. You also effectively refactored your code so that a single function doesn't try to do everything, such as with your get_arverage_rating, create_book, etc. functions. I also loved the way you commented your code. Great documentation!

Criteria 4: Uses Python Language Features

  • Score Level: 4/4
  • Comment(s): Your knowledge of Python and general computing is very apparent in your code. You consistently used Python language features where appropriate.

Overall Score: 15.5/16

Overall you did a fantastic job on this project! I can tell that you have learned a lot from the PWP course and hope you continue on with your Python journey. Just don't forget test cases and outputs next time!

@QuantVI
Copy link
Owner

QuantVI commented Nov 5, 2018

Thanks for the feedback. I mainly used what was in populate.py as my tests. Didn't realize I should add extra use cases to that file.

@QuantVI QuantVI closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants