Merge with default config #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * if you set authtoken using `ngrok config add-authtoken` and you also set config options in application properites we ignore the authtoken from the default config. This change addreses the need by: * use ngrok merge config feature by passing default config location config on the command line (iff the default config exists)
|
https://ngrok.com/docs/agent/config/#config-file-merging is the docs I used to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
ngrok config add-authtokenand youalso set config options in application properites
we ignore the authtoken from the default config.
This change addreses the need by:
config on the command line (iff the default config exists)