Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up kogito 1.39.0 / drools 8.39.0 #842

Merged
merged 1 commit into from May 26, 2023

Conversation

kie-ci
Copy link

@kie-ci kie-ci commented May 24, 2023

Generated by Kogito pipelines

@kie-ci kie-ci changed the title Bump up kogito to 1.39.0.Final Bump up kogito 1.39.0 / drools 8.39.0 May 24, 2023
@gsmet
Copy link
Member

gsmet commented May 24, 2023

The last commit is a bit concerning. Removing a component in a micro that late in the 2.16 cycle doesn't look like a good idea.

@gsmet
Copy link
Member

gsmet commented May 24, 2023

/cc @maxandersen ^

@aloubyansky
Copy link
Member

Agreed. This doesn't make sense.

@quarkus-bot

This comment has been minimized.

@mbiarnes
Copy link
Contributor

afaik OptaPlanner is not released any more together with drools and kogito. But OptaPlanner has a dependency to drools.
If we bump up drools to 8.39.0.Final but we don't bump up OptaPlanner, thean the latter one is pointing to the previous drools 8.38.0.Final version. This was the idea to remove all OptaPlanner stuff in quarkus-platform 2.16

@quarkus-bot

This comment has been minimized.

@radtriste
Copy link
Contributor

This is a fair point from Quarkus side. We need to discuss about this on our side ...

@mareknovotny
Copy link

if we can lower the relation to Drools and just let Optaplanner as it is, it would be the better option imho.

@quarkus-bot

This comment has been minimized.

@aloubyansky
Copy link
Member

If you force a new version of drools into the platform, will it actually break OptaPlanner?

@quarkus-bot

This comment has been minimized.

@mbiarnes
Copy link
Contributor

@aloubyansky that was the intitial problem why we thought it is better to remove OptaPlanner. OptaPlanner has a dependency to drools. If drools is being upgraded but OptaPlanner not IMO it could be that sooner or later OptaPlanner breaks.

@aloubyansky
Copy link
Member

As long as it's compatible though we should be upgrading. You could setup a CI to test OptaPlanner with the relevant branch of Drools to get early status on where this is going. We enforce different versions of Quarkus core regularly in the platform, for example.

@radtriste
Copy link
Contributor

As long as it's compatible though we should be upgrading. You could setup a CI to test OptaPlanner with the relevant branch of Drools to get early status on where this is going. We enforce different versions of Quarkus core regularly in the platform, for example.

Pipeline we already have.
My main concern was to update the Drools version in quarkus-universe-bom because OP defines hard dependencies on Drools. But seems that since we included Drools as a separate project, it is no issue anymore ...
In that case, we will release new version of OP only if Drools is breaking things for it.

@radtriste
Copy link
Contributor

@mbiarnes Can you finalize the PR ?

@kie-ci kie-ci force-pushed the bump-kogito-1.39.x-drools-8.39.x branch from 0d1ce37 to 3c8d69e Compare May 25, 2023 09:19
@kie-ci kie-ci force-pushed the bump-kogito-1.39.x-drools-8.39.x branch from 3c8d69e to 89b0f90 Compare May 25, 2023 09:35
@kie-ci kie-ci marked this pull request as ready for review May 25, 2023 09:38
@kie-ci
Copy link
Author

kie-ci commented May 25, 2023

@radtriste finalized drools & kogito

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2023

Failing Jobs - Building 3c8d69e

Status Name Step Failures Logs Raw logs
Build - JDK 11 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 11 #

- Failing:  

📦 Root project

Failed to execute goal io.quarkus:quarkus-platform-bom-maven-plugin:0.0.83:invoke-platform-project (build-platform-project) on project quarkus-platform-config: Failed to build the platform project, please consult the errors logged above.

📦 generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-lra

org.apache.camel.quarkus.component.lra.it.LraTest.testLraTransaction - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:625)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:696)

@radtriste
Copy link
Contributor

@aloubyansky @gsmet ready to merge

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radtriste

@gsmet gsmet merged commit e61e9d1 into quarkusio:2.16 May 26, 2023
3 of 4 checks passed
@radtriste radtriste deleted the bump-kogito-1.39.x-drools-8.39.x branch May 26, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants