Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default code gen not working in 1.8.0.CR1 #11915

Closed
maxandersen opened this issue Sep 4, 2020 · 10 comments
Closed

default code gen not working in 1.8.0.CR1 #11915

maxandersen opened this issue Sep 4, 2020 · 10 comments
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working priority/blocker triage/invalid This doesn't seem right
Milestone

Comments

@maxandersen
Copy link
Contributor

Describe the bug
following guide at https://quarkus.io/guides/redis using command:

mvn io.quarkus:quarkus-maven-plugin:1.7.2.Final:create \
    -DprojectGroupId=org.acme \
    -DprojectArtifactId=redis-quickstart \
    -Dextensions="redis-client, resteasy-jsonb, resteasy-mutiny"
cd redis-quickstart

the resulting project does not have any files in java nor test.

❯ tree
.
├── README.md
├── mvnw
├── mvnw.cmd
├── pom.xml
└── src
    ├── main
    │   ├── docker
    │   │   ├── Dockerfile.fast-jar
    │   │   ├── Dockerfile.jvm
    │   │   └── Dockerfile.native
    │   ├── java
    │   └── resources
    │       ├── META-INF
    │       │   └── resources
    │       │       └── index.html
    │       └── application.properties
    └── test
        └── java

9 directories, 9 files

Expected behavior
There should be a working example as in previous version.

@maxandersen maxandersen added kind/bug Something isn't working area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Sep 4, 2020
@maxandersen maxandersen added this to the 1.8.0.Final milestone Sep 4, 2020
@maxandersen
Copy link
Contributor Author

/cc @ia3andy any idea what is causing this ?

@gsmet
Copy link
Member

gsmet commented Sep 5, 2020

Needless to say this is highly critical and is a blocker.

@gsmet
Copy link
Member

gsmet commented Sep 5, 2020

Also, we need to check if it's an issue in 1.7 too.

@ia3andy
Copy link
Contributor

ia3andy commented Sep 5, 2020

Having a quick look, but I won't be able to spend long

@ia3andy
Copy link
Contributor

ia3andy commented Sep 5, 2020

Ok I can reproduce on 1.7.2.Final, 1.8.0.CR1 and master

@ia3andy
Copy link
Contributor

ia3andy commented Sep 5, 2020

className is null, I need to find why..

@ia3andy
Copy link
Contributor

ia3andy commented Sep 5, 2020

this doesn't seem to be due to the codestarts, I don't see where the className default value is set.. When this is no className we don't generate the classes..

@ia3andy
Copy link
Contributor

ia3andy commented Sep 5, 2020

Well this seems to be expected I see everywhere in the code: // If className is null, we won't create the REST resource,

And by default this is null...

    @Parameter(property = "className")
    private String className;

I let you see for the rest.

@ia3andy
Copy link
Contributor

ia3andy commented Sep 5, 2020

Ok I can reproduce on 1.6.0.Final this has been there forever.. going back to WE

@gsmet @maxandersen ⬆️

@maxandersen
Copy link
Contributor Author

Ahh. That's "fun" so we've had "empty" project gen I just never by chance not send without class name.

Closing as working as expected.

@gsmet gsmet added triage/invalid This doesn't seem right and removed triage/backport-1.7? labels Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working priority/blocker triage/invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants