Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to Quarkus 3 for extensions requiring Java 17 #33805

Open
zbendhiba opened this issue Jun 2, 2023 · 6 comments
Open

Migrating to Quarkus 3 for extensions requiring Java 17 #33805

zbendhiba opened this issue Jun 2, 2023 · 6 comments
Labels
area/upgradetool issues related to upgrade tooling (openrewrite, windup, cli, etc.) kind/enhancement New feature or request

Comments

@zbendhiba
Copy link
Contributor

Description

When migrating a Quarkus application from Quarkus 2.x to Quarkus 3.x using the quarkus update command, please note the following:

If the application is built using Java 11 and the Quarkus extensions now require a minimum of Java 17 (Camel extensions for example), it is necessary to migrate the project to Java 17. Failure to do so will result in the project not running, requiring the user to troubleshoot the issue.

Implementation ideas

No response

@zbendhiba zbendhiba added the kind/enhancement New feature or request label Jun 2, 2023
@yrodiere yrodiere added area/upgradetool issues related to upgrade tooling (openrewrite, windup, cli, etc.) and removed triage/needs-triage labels Jun 5, 2023
@ia3andy
Copy link
Contributor

ia3andy commented Jun 7, 2023

@gsmet is this possible with OpenRewrite? (update the Java version based on a dependency)

@ia3andy
Copy link
Contributor

ia3andy commented Jun 7, 2023

cc @maxandersen

@gsmet
Copy link
Member

gsmet commented Jun 7, 2023

Well, it should be possible by writing a custom rule. I don't think I will have the time to work on this though.

@maxandersen
Copy link
Contributor

Yeah, a custom rule seems simple enough @ia3andy ?

Just need the update tool to detect java 17 is needed for some of the updated extensions and then generate that as part of the generated script?

@maxandersen
Copy link
Contributor

Quick search finds multiple recipes for handling java tooling updates. One is https://docs.openrewrite.org/recipes/java/migrate/javaversion20 - similar variations for java 8 and 17 Afaics.

@gsmet
Copy link
Member

gsmet commented Jun 7, 2023

Updating the properties is easy but we need to detect the presence of the Camel extensions, that's why we need a custom rule.

Another option would be to hardcode it in the logic that generates the Quarkus version update recipes. But I don't think it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/upgradetool issues related to upgrade tooling (openrewrite, windup, cli, etc.) kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants