Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus.{kubernetes,openshift}.expose=true doesn't work #7650

Closed
Ladicek opened this issue Mar 6, 2020 · 4 comments · Fixed by #7652
Closed

quarkus.{kubernetes,openshift}.expose=true doesn't work #7650

Ladicek opened this issue Mar 6, 2020 · 4 comments · Fixed by #7652
Labels
kind/bug Something isn't working
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Mar 6, 2020

Describe the bug

I tried to migrate from the legacy kubernetes.expose=true / openshift.expose=true properties to the new quarkus.kubernetes.expose=true / quarkus.openshift.expose=true properties, but no Ingress / Route is being generated.

Also the KubernetesConfig / OpenshiftConfig classes don't have an expose field, so this looks like an important omission.

Expected behavior
Able to generate Ingress / Route by setting quarkus.{kubernetes,openshift}.expose=true, instead of the legacy {kubernetes,openshift}.expose=true.

Actual behavior
Setting quarkus.{kubernetes,openshift}.expose=true doesn't result in generated Ingress / Route.

To Reproduce
Steps to reproduce the behavior:

  1. Add the quarkus-kubernetes extension.
  2. Run mvn clean package.
  3. See target/kubernetes/*.yml.

Configuration

quarkus.kubernetes.deployment-target=kubernetes,openshift
quarkus.kubernetes.expose=true
quarkus.openshift.expose=true
@Ladicek Ladicek added the kind/bug Something isn't working label Mar 6, 2020
@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 6, 2020

CC @iocanel @geoand

@geoand
Copy link
Contributor

geoand commented Mar 6, 2020

I'll check it out, thanks for reporting

@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 6, 2020

I looked at how easy/hard this would be to fix, and found AddIngressDecorator / AddRouteDecorator in Dekorate. However, their constructors accept weird objects that I don't know how to obtain. Also these 2 classes seem to be quite different in how they handle labels, which is strange.

@geoand
Copy link
Contributor

geoand commented Mar 6, 2020

@iocanel do you have any better solution in mind other than adding some hard-coded support in KubernetesConfigUtil?

geoand added a commit to geoand/quarkus that referenced this issue Mar 6, 2020
geoand added a commit to geoand/quarkus that referenced this issue Mar 6, 2020
@gsmet gsmet added this to the 1.3.0.Final milestone Mar 6, 2020
geoand added a commit to geoand/quarkus that referenced this issue Mar 7, 2020
Fixes: quarkusio#7650

Co-Authored-By: Manyanda Chitimbo <manyanda.chitimbo@gmail.com>
machi1990 added a commit that referenced this issue Mar 7, 2020
Support Kubernetes expose property via Quarkus configuration
gsmet pushed a commit to gsmet/quarkus that referenced this issue Mar 8, 2020
Fixes: quarkusio#7650

Co-Authored-By: Manyanda Chitimbo <manyanda.chitimbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants