New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't generate docs when "quickly" sys prop is set to true #10523
Conversation
core/processor/src/main/java/io/quarkus/annotation/processor/Constants.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the followup!
Thanks for the review folks! |
I'm a bit torn about that one. The reason is that it's nice to be able to have a fast build with the documentation generated as it's the only way to get a clean doc generation without inclusion warnings hiding other potential issues. So I wonder if I would keep it the way it is and let people add |
IMHO, having to specify |
Well the thing is that you also need to check the doc at some point. If we are sure it won't end up with having a ton of PRs with doc issues then go ahead. |
I'm obviously not sure, I just think that this caters for the most common use case |
So I'll leave it up to you :) |
Looked at this again this morning and I think it's very counter intuitive to have to add |
@geoand so what should they do? Because when checking the docs properly, you need to build the whole tree. Anyway, I have my own aliases now as I don't think I will agree with all of you so feel free to do whatever you want with quickly :). |
The way I see What I would suggest for the docs, is exactly what you ended up doing, having your own aliases :) |
@geoand either you merge it or I close it, your call! :) |
I am in favor of merging, but CI seems to be stuck? |
I just rebased, let's see what happens |
Follows up on: #10230