New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify floating tag use in Mandrel builder images #11640
Conversation
Check https://quay.io/repository/quarkus/ubi-quarkus-mandrel?tab=tags[here] to find out about available tags. | ||
|
||
Please note that the above command points to a floating tag. | ||
It is highly recommended that use the floating tag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is highly recommended that use the floating tag, | |
It is highly recommended that you use the floating tag, |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine (other than the typo @gsmet pointed out).
Check https://quay.io/repository/quarkus/ubi-quarkus-mandrel?tab=tags[here] to find out about available tags. | ||
|
||
Please note that the above command points to a floating tag. | ||
It is highly recommended that use the floating tag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or:
It is highly recommended that use the floating tag, | |
It is highly recommended to use the floating tag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's probably better than my suggestion.
1d8fd24
to
112824e
Compare
Fixed the typo and force pushed, need to reduce the number of open PRs. |
Ok, thx @gsmet |
Follows up #11551.