Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify floating tag use in Mandrel builder images #11640

Merged
merged 1 commit into from Aug 27, 2020

Conversation

galderz
Copy link
Member

@galderz galderz commented Aug 26, 2020

Follows up #11551.

Check https://quay.io/repository/quarkus/ubi-quarkus-mandrel?tab=tags[here] to find out about available tags.

Please note that the above command points to a floating tag.
It is highly recommended that use the floating tag,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is highly recommended that use the floating tag,
It is highly recommended that you use the floating tag,

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine (other than the typo @gsmet pointed out).

Check https://quay.io/repository/quarkus/ubi-quarkus-mandrel?tab=tags[here] to find out about available tags.

Please note that the above command points to a floating tag.
It is highly recommended that use the floating tag,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or:

Suggested change
It is highly recommended that use the floating tag,
It is highly recommended to use the floating tag,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's probably better than my suggestion.

@gsmet gsmet force-pushed the t_clarification_floating_tag branch from 1d8fd24 to 112824e Compare August 27, 2020 10:41
@gsmet
Copy link
Member

gsmet commented Aug 27, 2020

Fixed the typo and force pushed, need to reduce the number of open PRs.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 27, 2020
@gsmet gsmet added this to the 1.8.0 - master milestone Aug 27, 2020
@gsmet gsmet merged commit 078f7c5 into quarkusio:master Aug 27, 2020
@galderz
Copy link
Member Author

galderz commented Aug 27, 2020

Ok, thx @gsmet

@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.2.Final Sep 1, 2020
@galderz galderz deleted the t_clarification_floating_tag branch March 18, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/mandrel triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants