Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions to set fast-jar flag #11850

Merged
merged 1 commit into from Sep 3, 2020

Conversation

lordofthejars
Copy link
Contributor

No description provided.

@boring-cyborg boring-cyborg bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Sep 3, 2020
@gsmet gsmet added this to the 1.9.0 - master milestone Sep 3, 2020
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 3, 2020
@jaikiran
Copy link
Member

jaikiran commented Sep 3, 2020

Failing with (of course unrelated to this PR):

2020-09-03T12:10:35.9036952Z [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 117.644 s <<< FAILURE! - in io.quarkus.cli.CliTest
2020-09-03T12:10:35.9041895Z [ERROR] io.quarkus.cli.CliTest.testAddListRemove  Time elapsed: 0.908 s  <<< FAILURE!
2020-09-03T12:10:35.9046067Z org.opentest4j.AssertionFailedError: expected: <quarkus-resteasy> but was: <>
2020-09-03T12:10:35.9051889Z 	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
2020-09-03T12:10:35.9057108Z 	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
2020-09-03T12:10:35.9061798Z 	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
2020-09-03T12:10:35.9065631Z 	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
2020-09-03T12:10:35.9069315Z 	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)
2020-09-03T12:10:35.9072874Z 	at io.quarkus.cli.CliTest.testAddListRemove(CliTest.java:90)

@jaikiran
Copy link
Member

jaikiran commented Sep 3, 2020

Given that this PR is about a change in the comment in a file and has been approved, I'll go ahead and merge this.

@ia3andy
Copy link
Contributor

ia3andy commented Sep 17, 2020

@gsmet we need to be really careful not to forget to update Codestarts templates too: #12166

gsmet pushed a commit to gsmet/quarkus that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants