Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves quarkus kakfa-streams extension devmode issue #12224

Merged
merged 1 commit into from Sep 30, 2020
Merged

Solves quarkus kakfa-streams extension devmode issue #12224

merged 1 commit into from Sep 30, 2020

Conversation

vietk
Copy link
Contributor

@vietk vietk commented Sep 21, 2020 •
edited by jaikiran

Fixes #12223

gunnarmorling
gunnarmorling reviewed Sep 21, 2020
View reviewed changes
Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions/suggestions inline.

...fka-streams/runtime/src/main/java/io/quarkus/kafka/streams/runtime/KafkaStreamsProducer.java Outdated Show resolved Hide resolved
.../src/main/java/io/quarkus/kafka/streams/runtime/devmode/KafkaStreamsHotReplacementSetup.java Outdated Show resolved Hide resolved
@vietk vietk force-pushed the bugfix/solve-kafka-streams-dev-mode branch from d08186f to 12c6613 Compare September 21, 2020 15:01
@gsmet
Copy link
Member

gsmet commented Sep 28, 2020

@stuartwdouglas I'm intrigued by this one? I would have expected the class to be reloaded in a new CL when dev mode restarts the app?

@vietk
Copy link
Contributor Author

vietk commented Sep 28, 2020

@gsmet : Was wondering the same before submitting a PR. But I saw that the dev mode is 'playing' with many classloaders, looking at the code.
I end thinking that there's an "application" classloader and an "extension" classloader, but I would like to understand it all too.

@stuartwdouglas
Copy link
Member

We don't reload the extensions, just the user code. Class loading is really expensive, you don't want to have to reload everything on dev mode restart (and you needs lots of things to stick around anyway like the HTTP connection).

@gsmet gsmet merged commit 9d3ebaf into quarkusio:master Sep 30, 2020
@gsmet gsmet modified the milestones: 1.9.0 - master, 1.8.2.Final Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rquinio rquinio rquinio left review comments

@gsmet gsmet gsmet approved these changes

@gunnarmorling gunnarmorling Awaiting requested review from gunnarmorling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.2.Final
Development

Successfully merging this pull request may close these issues.

Kafka-streams dev mode broken
5 participants
@vietk @gsmet @stuartwdouglas @gunnarmorling @rquinio