Fix the handling of the port 0 #12401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By updating the options object, it create a race conditions. One verticle may be already listening and would have updated the port in the HTTP option. So, the next verticle see this set port (no more 0) and try to bind on that port, which lead to a BindException. This commit stores the actual HTTP and HTTPS port without modifying the HTTP options.
|
@phillip-kruger That fixes the MQTT client issue :-) |
This was referenced Sep 29, 2020
stuartwdouglas
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By updating the options object, it create a race conditions.
One verticle may be already listening and would have updated the port in the HTTP option.
So, the next verticle see this set port (no more 0) and try to bind on that port, which lead to a BindException.
This commit stores the actual HTTP and HTTPS port without modifying the HTTP options.