Add @JsonView support to quarkus-resteasy-reactive-jackson #13561
Conversation
ghost
added
the
...t/src/test/java/io/quarkus/resteasy/reactive/jackson/deployment/test/SimpleJsonResource.java
Show resolved
Hide resolved
| Set<String> classesNeedingReflectionOnMethods = new HashSet<>(); | ||
| for (ClassInfo resourceClass : resourceClasses) { | ||
| if (resourceClass.annotations().containsKey(JSON_VIEW)) { | ||
| classesNeedingReflectionOnMethods.add(resourceClass.name().toString()); |
There was a problem hiding this comment.
Sorry to be that guy but shouldn't we do this in the quarkus-jackson extension given it's a generic Jackson annotation?
It could be used in other extensions then.
And I would do it for all @JsonView annotations in the classpath.
There was a problem hiding this comment.
No, because this reflection is only needed in order to make resteasy-reactive work. Normally RESTEasy reactive does not have to perform reflection on the resource method, but in this case (and in other that we will surely find later on) it does.
That means that this reflection is resteasy-reactive specific, not Jackson specific.
There was a problem hiding this comment.
Maybe I'm missing something but if we do need reflection for the class referenced in JsonView, I think it's a general requirement.
I'm not sure though if you added reflection for that?
There was a problem hiding this comment.
We are not doing reflection for the class referenced in the annotation, but for the class that contains the resource method in question.
Perhaps the variables names are not clear enough?
There was a problem hiding this comment.
They are clear but I'm still puzzled on how it can work without having the class in @JsonView registered for reflection.
There was a problem hiding this comment.
Why do you think the value needs to be registered? Jackson almost certainly doesn't need to do any reflection on this class. It probably just has to call isAssignable on the class
Fixes: #13566