New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document bootstrap config options and tooling #2436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aloubyansky looks mostly good. I added a few minor comments. I let you take a look and fix them before merging if you think it's appropriate?
|
||
Usually, dependencies of an application (which is a Maven project) could be displayed using `mvn dependency:tree` command. In case of a Quarkus application, however, this command will list only the runtime dependencies of the application. | ||
Given that the Quarkus build process adds deployment dependencies of the extensions used in the application to the original application classpath, it could be useful to know which dependencies and which versions end up on the build classpath. | ||
Luckily, `quarkus-bootstrap` maven plugin includes `build-tree` goal which displays the build dependency tree for the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's minor but I would go with
**the** `quarkus-bootstrap` **M**aven plugin includes **a** `build-tree` goal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "a build-tree
"? build-tree is a name of the goal. As well as quarkus-bootstrap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it reads better with an article. "It includes a goal."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's not "It includes a goal." It names the goal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either a
or the
would read better IMHO. But feel free to merge as is. I approved it :)
|
||
Now you should be able to execute `mvn quarkus-bootstrap:build-tree` on your project and see something like: | ||
|
||
[source,shell] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can use ,subs=attributes+
here and use {quarkus-version}
below?
Fix for #2353