Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape properties in filtered pom.xml of integration-tests/maven and integration-tests/kubernetes #33742

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented May 31, 2023

Fixes #33630

@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member Author

gsmet commented Jun 6, 2023

Hey @maxandersen could we merge this one to start making progress on the Gradle build scan thingy?

@jprinet
Copy link
Contributor

jprinet commented Jun 8, 2023

Hey @maxandersen could we merge this one to start making progress on the Gradle build scan thingy?

Hi @gsmet, I am just confirming that this PR fixes most of the differences found in the pom.xml, there is however the integration-tests/container-image/maven-invoker-way module which is not considered.

Could you escape the maven.home and native.image.path for those pom.xml files as well?

@maxandersen maxandersen merged commit adcaefc into quarkusio:main Jun 8, 2023
45 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 8, 2023
@jprinet
Copy link
Contributor

jprinet commented Jun 8, 2023

Hi @gsmet, I am just confirming that this PR fixes most of the differences found in the pom.xml, there is however the integration-tests/container-image/maven-invoker-way module which is not considered.

Could you escape the maven.home and native.image.path for those pom.xml files as well?

Do you want me to take care of the remaining pom.xml in another PR @gsmet @maxandersen ?

@maxandersen
Copy link
Contributor

Yeah. Lets do others in separate prs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native.image.path have absolute path in generated pom
3 participants