Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Kogito components versions in Quarkus #4154

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@cristianonicolai
Copy link
Contributor

cristianonicolai commented Sep 23, 2019

No description provided.

@cristianonicolai

This comment has been minimized.

Copy link
Contributor Author

cristianonicolai commented Sep 23, 2019

@wburns @tristantarrant @gsmet please take a look, I'm locking the Infinispan to ensure the expected versions, as some of the Kogito dependencies also use Infinispan.

@mswiderski fyi

@mkouba mkouba requested review from wburns and gsmet and removed request for wburns Sep 23, 2019
<version>${kogito.version}</version>
<scope>import</scope>
<type>pom</type>
</dependency>

This comment has been minimized.

Copy link
@gsmet

gsmet Sep 23, 2019

Member

I'm not sure it's worth it to import the Kogito BOM. Can't the users import both the Quarkus BOM and the Kogito BOM in their apps?

/cc @aloubyansky

This comment has been minimized.

Copy link
@wburns

wburns Sep 23, 2019

Member

That is my sentiment as well, however I am not a maven black wizard :)

This comment has been minimized.

Copy link
@mswiderski

mswiderski Sep 23, 2019

Contributor

Main reason is to avoid version mismatch different kogito version coming with quarkus and then different one selected by users

This comment has been minimized.

Copy link
@gsmet

gsmet Sep 24, 2019

Member

Yeah, I see the point of it. My main interrogation is: should we add the BOM of all the technologies we use in our BOM. Kogito being a very specific component, I was thinking that maybe the user could include the BOM themselves.

I know @aloubyansky was a bit reluctant to add too many BOMs in ours.

This comment has been minimized.

Copy link
@aloubyansky

aloubyansky Sep 24, 2019

Member

There is a supported extension for Kogito, so in this regard it's not different from other supported extensions that added their BOMs to the Quarkus one. So, based on that, I'd say lets add it.
However, this is something to think about, as our BOM will keep expanding a lot and rapidly. We may want to consider having a pure Quarkus-core BOM and then let users (and/or our tolling) import the rest separately. There will be different issues with that approach though.

@@ -1976,11 +1985,36 @@
<artifactId>infinispan-commons</artifactId>
<version>${infinispan.version}</version>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-lucene-directory</artifactId>

This comment has been minimized.

Copy link
@wburns

wburns Sep 23, 2019

Member

Is there a reason we are including lucene and directory providers here? These are server artifacts that aren't going to be supported in Quarkus native mode since lucene is not supported there.

This comment has been minimized.

Copy link
@cristianonicolai

cristianonicolai Sep 23, 2019

Author Contributor

@wburns added it here so that the correct versions are enforced in quarkus-integration-test-infinispan-client. I believe these deps get pulled in order to run the InfinispanServerTestResource.

This comment has been minimized.

Copy link
@gsmet

gsmet Sep 24, 2019

Member

@wburns are the answers OK for you?

This comment has been minimized.

Copy link
@wburns

wburns Sep 24, 2019

Member

Seems okay to me.

@gsmet gsmet changed the title KOGITO-249 - Align Kogito components versions in Quarkus Align Kogito components versions in Quarkus Sep 24, 2019
@gsmet
gsmet approved these changes Sep 24, 2019
Copy link
Member

gsmet left a comment

OK, looks like everyone is OK with it, let's merge then.

@gsmet gsmet added this to the 0.24.0 milestone Sep 24, 2019
@gsmet gsmet merged commit 6658751 into quarkusio:master Sep 24, 2019
22 checks passed
22 checks passed
quarkusio.quarkus Build #20190923.17 succeeded
Details
quarkusio.quarkus (Build for Native Build JDK8 Linux) Build for Native Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Maven Cache Linux Maven Repo) Maven Cache Linux Maven Repo succeeded
Details
quarkusio.quarkus (Maven Cache Windows Maven Repo) Maven Cache Windows Maven Repo succeeded
Details
quarkusio.quarkus (Native Tests amazon-dynamodb, amazon-lambda) Native Tests amazon-dynamodb, amazon-lambda succeeded
Details
quarkusio.quarkus (Native Tests artemis-core, artemis-jms, kafka) Native Tests artemis-core, artemis-jms, kafka succeeded
Details
quarkusio.quarkus (Native Tests elytron-security-oauth2, elytron-security, keycloak) Native Tests elytron-security-oauth2, elytron-security, keycloak succeeded
Details
quarkusio.quarkus (Native Tests flyway, hibernate-orm-panache, reactive-pg-client) Native Tests flyway, hibernate-orm-panache, reactive-pg-client succeeded
Details
quarkusio.quarkus (Native Tests hibernate-search-elasticsearch) Native Tests hibernate-search-elasticsearch succeeded
Details
quarkusio.quarkus (Native Tests infinispan-cache-jpa, infinispan-client, mongodb-client, neo4j) Native Tests infinispan-cache-jpa, infinispan-client, mongodb-client, neo4j succeeded
Details
quarkusio.quarkus (Native Tests jackson, jgit, kogito, kubernetes-client) Native Tests jackson, jgit, kogito, kubernetes-client succeeded
Details
quarkusio.quarkus (Native Tests jpa, jpa-postgresql) Native Tests jpa, jpa-postgresql succeeded
Details
quarkusio.quarkus (Native Tests jpa-h2, jpa-mariadb, jpa-mssql) Native Tests jpa-h2, jpa-mariadb, jpa-mssql succeeded
Details
quarkusio.quarkus (Native Tests main) Native Tests main succeeded
Details
quarkusio.quarkus (Native Tests resteasy-jackson, vertx, vertx-http, virtual-http) Native Tests resteasy-jackson, vertx, vertx-http, virtual-http succeeded
Details
quarkusio.quarkus (Native Tests spring-di, spring-web, spring-data-jpa) Native Tests spring-di, spring-web, spring-data-jpa succeeded
Details
quarkusio.quarkus (Native Tests tika, hibernate-validator, test-extension) Native Tests tika, hibernate-validator, test-extension succeeded
Details
quarkusio.quarkus (Run JVM Tests Build JDK8 Linux) Run JVM Tests Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK11 Build) Run JVM Tests Linux JDK11 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK12 Build) Run JVM Tests Linux JDK12 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Run_TCKs) Run JVM Tests Run_TCKs succeeded
Details
quarkusio.quarkus (Run JVM Tests Windows JVM Build) Run JVM Tests Windows JVM Build succeeded
Details
@cristianonicolai cristianonicolai deleted the cristianonicolai:KOGITO-249 branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.