Skip to content

/quarkus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertx web - use shared BodyHandler instance #4314

Merged
merged 1 commit into from Oct 3, 2019
Merged

Vertx web - use shared BodyHandler instance #4314

merged 1 commit into from Oct 3, 2019

Conversation

@mkouba
Copy link
Contributor

mkouba commented Oct 2, 2019

@mkouba mkouba requested a review from cescoffier Oct 2, 2019
@mkouba mkouba added this to the 0.24.0 milestone Oct 2, 2019
@cescoffier
cescoffier approved these changes Oct 2, 2019
View changes
@mkouba

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

mkouba commented Oct 2, 2019

Native Tests main fails with many occurrences of:

Caused by: com.oracle.svm.core.jdk.UnsupportedFeatureError: Proxy class defined by interfaces [interface javax.servlet.http.HttpServletRequest] not found. Generating proxy classes at runtime is not supported. Proxy classes need to be defined at image build time by specifying the list of interfaces that they implement. To define proxy classes use -H:DynamicProxyConfigurationFiles=<comma-separated-config-files> and -H:DynamicProxyConfigurationResources=<comma-separated-config-resources> options.

Does anybody have an idea?
@cescoffier

This comment has been minimized.

Sign in to view
Copy link
Member

cescoffier commented Oct 3, 2019

can you rebase, it may have been fixed.
@mkouba
Vertx web - use shared BodyHandler instance
Loading status checks…
69c306d 
- resolves #4294
@mkouba mkouba force-pushed the mkouba:issue-4294-vertx-body-handler branch from 9225860 to 69c306d Oct 3, 2019
@mkouba

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

mkouba commented Oct 3, 2019

Rebased...
@stuartwdouglas stuartwdouglas merged commit 95aa4b8 into quarkusio:master Oct 3, 2019
22 checks passed
22 checks passed
quarkusio.quarkus Build #20191003.21 succeeded
Details
quarkusio.quarkus (Build for Native Build JDK8 Linux) Build for Native Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Maven Cache Linux Maven Repo) Maven Cache Linux Maven Repo succeeded
Details
quarkusio.quarkus (Maven Cache Windows Maven Repo) Maven Cache Windows Maven Repo succeeded
Details
quarkusio.quarkus (Native Tests amazon-dynamodb, amazon-lambda) Native Tests amazon-dynamodb, amazon-lambda succeeded
Details
quarkusio.quarkus (Native Tests artemis-core, artemis-jms, kafka) Native Tests artemis-core, artemis-jms, kafka succeeded
Details
quarkusio.quarkus (Native Tests elytron-security-oauth2, elytron-security, keycloak) Native Tests elytron-security-oauth2, elytron-security, keycloak succeeded
Details
quarkusio.quarkus (Native Tests flyway, hibernate-orm-panache, reactive-pg-client) Native Tests flyway, hibernate-orm-panache, reactive-pg-client succeeded
Details
quarkusio.quarkus (Native Tests hibernate-search-elasticsearch) Native Tests hibernate-search-elasticsearch succeeded
Details
quarkusio.quarkus (Native Tests infinispan-cache-jpa, infinispan-client, mongodb-client, mongodb-panache, neo4j, narayana-stm) Native Tests infinispan-cache-jpa, infinispan-client, mongodb-client, mongodb-panache, neo4j, narayana-stm succeeded
Details
quarkusio.quarkus (Native Tests jackson, jgit, kogito, kubernetes-client) Native Tests jackson, jgit, kogito, kubernetes-client succeeded
Details
quarkusio.quarkus (Native Tests jpa, jpa-postgresql, jpa-mysql) Native Tests jpa, jpa-postgresql, jpa-mysql succeeded
Details
quarkusio.quarkus (Native Tests jpa-h2, jpa-mariadb, jpa-mssql) Native Tests jpa-h2, jpa-mariadb, jpa-mssql succeeded
Details
quarkusio.quarkus (Native Tests main) Native Tests main succeeded
Details
quarkusio.quarkus (Native Tests resteasy-jackson, vertx, vertx-http, virtual-http) Native Tests resteasy-jackson, vertx, vertx-http, virtual-http succeeded
Details
quarkusio.quarkus (Native Tests spring-di, spring-web, spring-data-jpa) Native Tests spring-di, spring-web, spring-data-jpa succeeded
Details
quarkusio.quarkus (Native Tests tika, hibernate-validator, test-extension) Native Tests tika, hibernate-validator, test-extension succeeded
Details
quarkusio.quarkus (Run JVM Tests Build JDK8 Linux) Run JVM Tests Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK11 Build) Run JVM Tests Linux JDK11 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK12 Build) Run JVM Tests Linux JDK12 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Run_TCKs) Run JVM Tests Run_TCKs succeeded
Details
quarkusio.quarkus (Run JVM Tests Windows JVM Build) Run JVM Tests Windows JVM Build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier

Assignees
No one assigned
Labels
bug component:vertx
Projects
None yet
Milestone
  0.24.0
3 participants
@mkouba @cescoffier @stuartwdouglas
You can’t perform that action at this time.