Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial copy of Derby extension #4424

Merged
merged 3 commits into from Oct 14, 2019

Conversation

@aguibert
Copy link
Contributor

aguibert commented Oct 7, 2019

Working directly with @Sanne on this, but anyone is welcome to commend and discuss!

Fixes #4442

@stuartwdouglas

This comment has been minimized.

Copy link
Member

stuartwdouglas commented Oct 8, 2019

Looks like format validation failed. Can you run 'mvn process-sources' and push an amended commit?

We have really strict formatting rules but the default maven build automatically formats, so if you build from maven before pushing you should not run into this again.

@aguibert

This comment has been minimized.

Copy link
Contributor Author

aguibert commented Oct 8, 2019

Thanks for the review comments already @stuartwdouglas and @cescoffier! This PR was just a draft so not fully polished yet, but I appreciate you guys taking the time to look it over in the early stages.

@aguibert

This comment has been minimized.

Copy link
Contributor Author

aguibert commented Oct 8, 2019

@stuartwdouglas I have been running various flavors of mvn install a lot on the projects I am contributing, I assume the formatting goal would be part of this chain? I also tried running mvn process-sources in /quarkus/extensions/jdbc/jdbc-derby and /quarkus/integration-tests/jpa-derby/ but it did modify any of the files.

I'm not too familiar with azure pipelines, but I take it the formatting failure is described somewhere in the build output? I've tried to view the build results myself (specifically this link) but it's not loading for me -- perhaps they have been auto-deleted by now?

Copy link
Member

gsmet left a comment

Overall, looks good to me (hi Andy!). I added a couple of comments here and there.

@aguibert aguibert force-pushed the aguibert:jdbc-derby branch from 059eefc to 2461ea8 Oct 8, 2019
@stuartwdouglas

This comment has been minimized.

Copy link
Member

stuartwdouglas commented Oct 8, 2019

That link worked fine for me, AFAIK the results should be public so you should be able to see them as well. To see the logs you need to click on the 'Linux Maven Repo' task.

If you run mvn install it should auto format for you. I also use the following in '.git/hooks/pre-push'

#!/bin/sh
mvn process-sources -Dno-format -Denforcer.skip -Dmaven.buildNumber.skip

This will check before pushing (if you want to save time as you know it is ok you can use --no-verify when you push)

@aguibert aguibert force-pushed the aguibert:jdbc-derby branch from 2461ea8 to 69d45bb Oct 11, 2019
@aguibert aguibert force-pushed the aguibert:jdbc-derby branch from 69d45bb to 439ddee Oct 11, 2019
@aguibert aguibert marked this pull request as ready for review Oct 11, 2019
@aguibert aguibert requested review from gsmet, cescoffier and Sanne Oct 11, 2019
@aguibert

This comment has been minimized.

Copy link
Contributor Author

aguibert commented Oct 14, 2019

PR is now updated with all review comment feedback, as well as CI checks passing.

@Sanne @cescoffier @gsmet please re-review when you get a chance. Thanks!

Copy link
Member

cescoffier left a comment

Looks good to me, but I'm not a database guy.
Will let @Sanne do more meaningful comments

public static final String JDBC_POSTGRESQL = "jdbc-postgresql";
public static final String JDBC_MARIADB = "jdbc-mariadb";

This comment has been minimized.

Copy link
@machi1990

machi1990 Oct 14, 2019

Member

a very minor comment - I think the constants are sorted in alphabetically. We should preserve that :-)

@Sanne
Sanne approved these changes Oct 14, 2019
Copy link
Member

Sanne left a comment

Seems ready to go! Just missed to mention the new Maven modules in the respective parents, I added that.

Thanks!

@Sanne Sanne dismissed stale reviews from gsmet and cescoffier Oct 14, 2019

Comments addressed

@Sanne Sanne merged commit 9dcaa18 into quarkusio:master Oct 14, 2019
2 of 3 checks passed
2 of 3 checks passed
quarkusio.quarkus Build #20191014.31 failed
Details
quarkusio.quarkus (Maven Cache Linux Maven Repo) Maven Cache Linux Maven Repo succeeded
Details
quarkusio.quarkus (Maven Cache Windows Maven Repo) Maven Cache Windows Maven Repo succeeded
Details
@Sanne Sanne added this to the 0.25.0 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.