Initial copy of Derby extension

[aguibert]

Working directly with @Sanne on this, but anyone is welcome to commend and discuss!

Fixes #4442

[stuartwdouglas]

Looks like format validation failed. Can you run 'mvn process-sources' and push an amended commit?

We have really strict formatting rules but the default maven build automatically formats, so if you build from maven before pushing you should not run into this again.

[aguibert]

Thanks for the review comments already @stuartwdouglas and @cescoffier! This PR was just a draft so not fully polished yet, but I appreciate you guys taking the time to look it over in the early stages.

[aguibert]

@stuartwdouglas I have been running various flavors of mvn install a lot on the projects I am contributing, I assume the formatting goal would be part of this chain? I also tried running mvn process-sources in /quarkus/extensions/jdbc/jdbc-derby and /quarkus/integration-tests/jpa-derby/ but it did modify any of the files.

I'm not too familiar with azure pipelines, but I take it the formatting failure is described somewhere in the build output? I've tried to view the build results myself (specifically this link) but it's not loading for me -- perhaps they have been auto-deleted by now?

[gsmet]

Overall, looks good to me (hi Andy!). I added a couple of comments here and there.

[stuartwdouglas]

That link worked fine for me, AFAIK the results should be public so you should be able to see them as well. To see the logs you need to click on the 'Linux Maven Repo' task.

If you run mvn install it should auto format for you. I also use the following in '.git/hooks/pre-push'

#!/bin/sh
mvn process-sources -Dno-format -Denforcer.skip -Dmaven.buildNumber.skip

This will check before pushing (if you want to save time as you know it is ok you can use --no-verify when you push)

[aguibert]

PR is now updated with all review comment feedback, as well as CI checks passing.

@Sanne @cescoffier @gsmet please re-review when you get a chance. Thanks!

[cescoffier]

Looks good to me, but I'm not a database guy.
Will let @Sanne do more meaningful comments

[machi1990]

a very minor comment - I think the constants are sorted in alphabetically. We should preserve that :-)

[Sanne]

Seems ready to go! Just missed to mention the new Maven modules in the respective parents, I added that.

Thanks!

Comments addressed