Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support outputDirectory in CreateProjectMojo #4932

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@gastaldi
Copy link
Collaborator

gastaldi commented Oct 28, 2019

This will allow the quarkus:create to be used on any directory and also useful in pom.xml when wanting to generate a project during the build

This will allow the quarkus:create to be used on any directory and also useful in pom.xml when wanting to generate a project automatically
@gastaldi gastaldi requested review from aloubyansky and geoand Oct 28, 2019
@geoand

This comment has been minimized.

Copy link
Contributor

geoand commented Oct 28, 2019

So I assume this is also useful in integration tests?

@gastaldi

This comment has been minimized.

Copy link
Collaborator Author

gastaldi commented Oct 28, 2019

Yes, specially for integration tests 😃

@geoand
geoand approved these changes Oct 28, 2019
@gsmet

This comment has been minimized.

Copy link
Member

gsmet commented Oct 28, 2019

If we are playing with that, could we make the command entirely consistent and always create the project in a new directory?

The current behavior is highly disturbing, especially when you have hidden files in the directory.

@gsmet

This comment has been minimized.

Copy link
Member

gsmet commented Oct 28, 2019

Note that it doesn't have to be done in this PR. I don't want to block it.

@gastaldi

This comment has been minimized.

Copy link
Collaborator Author

gastaldi commented Oct 28, 2019

@gsmet So the default value for outputDirectory should be ${basedir}/${projectArtifactId} ? I'm fine with changing that if everyone agrees

@gastaldi

This comment has been minimized.

Copy link
Collaborator Author

gastaldi commented Oct 28, 2019

Note that it doesn't have to be done in this PR. I don't want to block it.

Right, I prefer to keep the same behavior and introduce a new PR with this change

@gastaldi gastaldi added this to the 0.27.0 milestone Oct 28, 2019
@geoand geoand merged commit c6625e9 into quarkusio:master Oct 28, 2019
24 checks passed
24 checks passed
WIP Ready for review
Details
quarkusio.quarkus Build #20191028.41 succeeded
Details
quarkusio.quarkus (Build for Native Build JDK8 Linux) Build for Native Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Maven Cache Linux Maven Repo) Maven Cache Linux Maven Repo succeeded
Details
quarkusio.quarkus (Maven Cache Windows Maven Repo) Maven Cache Windows Maven Repo succeeded
Details
quarkusio.quarkus (Native Tests amazon-dynamodb, amazon-lambda, amazon-lambda-http-it) Native Tests amazon-dynamodb, amazon-lambda, amazon-lambda-http-it succeeded
Details
quarkusio.quarkus (Native Tests artemis-core, artemis-jms, kafka) Native Tests artemis-core, artemis-jms, kafka succeeded
Details
quarkusio.quarkus (Native Tests elytron-security-oauth2, elytron-security, elytron-security-jdbc, elytron-undertow, elytron-resteasy, oidc, vault-app, keycloak-authorization) Native Tests elytron-security-oauth2, elytron-security, elytron-security-jdbc, elytron-undertow, elytron-resteasy, oidc, vault-app, keycloak-authorization succeeded
Details
quarkusio.quarkus (Native Tests flyway, hibernate-orm-panache, reactive-pg-client) Native Tests flyway, hibernate-orm-panache, reactive-pg-client succeeded
Details
quarkusio.quarkus (Native Tests hibernate-search-elasticsearch) Native Tests hibernate-search-elasticsearch succeeded
Details
quarkusio.quarkus (Native Tests infinispan-cache-jpa, infinispan-client) Native Tests infinispan-cache-jpa, infinispan-client succeeded
Details
quarkusio.quarkus (Native Tests jackson, jsonb, jgit, kogito, kubernetes-client) Native Tests jackson, jsonb, jgit, kogito, kubernetes-client succeeded
Details
quarkusio.quarkus (Native Tests jpa, jpa-postgresql, jpa-mysql, reactive-mysql-client) Native Tests jpa, jpa-postgresql, jpa-mysql, reactive-mysql-client succeeded
Details
quarkusio.quarkus (Native Tests jpa-h2, jpa-mariadb, jpa-mssql, jpa-derby) Native Tests jpa-h2, jpa-mariadb, jpa-mssql, jpa-derby succeeded
Details
quarkusio.quarkus (Native Tests main) Native Tests main succeeded
Details
quarkusio.quarkus (Native Tests mongodb-client, mongodb-panache, neo4j, narayana-stm, narayana-jta) Native Tests mongodb-client, mongodb-panache, neo4j, narayana-stm, narayana-jta succeeded
Details
quarkusio.quarkus (Native Tests resteasy-jackson, vertx, vertx-http, virtual-http) Native Tests resteasy-jackson, vertx, vertx-http, virtual-http succeeded
Details
quarkusio.quarkus (Native Tests spring-di, spring-web, spring-data-jpa) Native Tests spring-di, spring-web, spring-data-jpa succeeded
Details
quarkusio.quarkus (Native Tests tika, hibernate-validator, test-extension) Native Tests tika, hibernate-validator, test-extension succeeded
Details
quarkusio.quarkus (Run JVM Tests Build JDK8 Linux) Run JVM Tests Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK11 Build) Run JVM Tests Linux JDK11 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK12 Build) Run JVM Tests Linux JDK12 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Run_TCKs) Run JVM Tests Run_TCKs succeeded
Details
quarkusio.quarkus (Run JVM Tests Windows JVM Build) Run JVM Tests Windows JVM Build succeeded
Details
@gastaldi gastaldi deleted the gastaldi:create_mojo branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.