Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: NoSuchFileException in logs and improper caching in devmode after removing a html file #5182

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@machi1990
Copy link
Member

machi1990 commented Nov 4, 2019

This includes two fixes after I have rebased my work with @jmartisk initial work - #5165

  • first commit NoSuchFileException in logs as proposed by @jmartisk
  • second commit make sure that resource files are properly registered before first http request in dev mode.

/cc @jmartisk I rebased on top of #5165 to avoid hitting the missing file exception fixed by your PR.

Copy link
Member

gsmet left a comment

Added a question. If it's easy it's worth doing it IMHO.

jmartisk and others added 2 commits Nov 4, 2019
… the first request

fixes #5163
@machi1990 machi1990 force-pushed the machi1990:fix/5163 branch from f10318b to 0b33537 Nov 4, 2019
@machi1990 machi1990 requested a review from gsmet Nov 4, 2019
@gsmet
gsmet approved these changes Nov 4, 2019
@gsmet

This comment has been minimized.

Copy link
Member

gsmet commented Nov 4, 2019

@jmartisk can you check it fixes the issue you reported? I'd like to backport it at some point so better be sure.

Thanks!

@machi1990

This comment has been minimized.

Copy link
Member Author

machi1990 commented Nov 4, 2019

Thanks all. CI failure looks unrelated.

@gsmet gsmet merged commit b651d6e into quarkusio:master Nov 4, 2019
22 of 24 checks passed
22 of 24 checks passed
quarkusio.quarkus Build #20191104.53 had test failures
Details
quarkusio.quarkus ((Expansion) Native Tests artemis-core, artemis-jms, kafka) (Expansion) Native Tests artemis-core, artemis-jms, kafka failed
Details
WIP Ready for review
Details
quarkusio.quarkus ((Expansion) Build for Native Build JDK8 Linux) (Expansion) Build for Native Build JDK8 Linux succeeded
Details
quarkusio.quarkus ((Expansion) Maven Cache Linux Maven Repo) (Expansion) Maven Cache Linux Maven Repo succeeded
Details
quarkusio.quarkus ((Expansion) Maven Cache Windows Maven Repo) (Expansion) Maven Cache Windows Maven Repo succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests amazon-dynamodb, amazon-lambda, amazon-lambda-http) (Expansion) Native Tests amazon-dynamodb, amazon-lambda, amazon-lambda-http succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests elytron-resteasy, oidc, oidc-code-flow, vault-app, keycloak-authorization) (Expansion) Native Tests elytron-resteasy, oidc, oidc-code-flow, vault-app, keycloak-authorization succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests elytron-security-oauth2, elytron-security, elytron-security-jdbc, elytron-undertow) (Expansion) Native Tests elytron-security-oauth2, elytron-security, elytron-security-jdbc, elytron-undertow succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests flyway, hibernate-orm-panache, reactive-pg-client) (Expansion) Native Tests flyway, hibernate-orm-panache, reactive-pg-client succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests hibernate-search-elasticsearch, narayana-stm, narayana-jta) (Expansion) Native Tests hibernate-search-elasticsearch, narayana-stm, narayana-jta succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests infinispan-cache-jpa, infinispan-client) (Expansion) Native Tests infinispan-cache-jpa, infinispan-client succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests jackson, jsonb, jgit, kogito, kubernetes-client) (Expansion) Native Tests jackson, jsonb, jgit, kogito, kubernetes-client succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests jpa, jpa-postgresql, jpa-mysql, reactive-mysql-client) (Expansion) Native Tests jpa, jpa-postgresql, jpa-mysql, reactive-mysql-client succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests jpa-h2, jpa-mariadb, jpa-mssql, jpa-derby) (Expansion) Native Tests jpa-h2, jpa-mariadb, jpa-mssql, jpa-derby succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests main) (Expansion) Native Tests main succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests mongodb-client, mongodb-panache, neo4j) (Expansion) Native Tests mongodb-client, mongodb-panache, neo4j succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests resteasy-jackson, vertx, vertx-http, virtual-http) (Expansion) Native Tests resteasy-jackson, vertx, vertx-http, virtual-http succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests spring-di, spring-web, spring-data-jpa) (Expansion) Native Tests spring-di, spring-web, spring-data-jpa succeeded
Details
quarkusio.quarkus ((Expansion) Native Tests tika, hibernate-validator, test-extension) (Expansion) Native Tests tika, hibernate-validator, test-extension succeeded
Details
quarkusio.quarkus ((Expansion) Run JVM Tests Linux JDK11 Build) (Expansion) Run JVM Tests Linux JDK11 Build succeeded
Details
quarkusio.quarkus ((Expansion) Run JVM Tests Linux JDK12 Build) (Expansion) Run JVM Tests Linux JDK12 Build succeeded
Details
quarkusio.quarkus ((Expansion) Run JVM Tests Run_TCKs) (Expansion) Run JVM Tests Run_TCKs succeeded
Details
quarkusio.quarkus ((Expansion) Run JVM Tests Windows JVM Build) (Expansion) Run JVM Tests Windows JVM Build succeeded
Details
@gsmet gsmet added this to the 0.29.0 milestone Nov 4, 2019
@machi1990 machi1990 deleted the machi1990:fix/5163 branch Nov 4, 2019
@gsmet gsmet modified the milestones: 0.29.0, 0.28.2 Nov 5, 2019
@gsmet gsmet removed the backport? label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.