Integration of Qute and Mutiny #7101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by Mutiny Also remove the SmallRye Reactive Streams Operators dependency - not required anymore.
boring-cyborg
bot
added
area/dependencies
gsmet
reviewed
Feb 10, 2020
| Uni<String> uni = Uni.createFrom().completionStage(() -> template.data("name", "neo").renderAsync()); | ||
| ---- | ||
|
|
||
| In this case, the rendering only starts once the subscriber requests it. |
There was a problem hiding this comment.
Looks like it's the same in both cases? Or did I misunderstand something?
There was a problem hiding this comment.
If you use a renderAsync() the rendering process starts even if you don't have anyone listening / prepared to receive the output. With Uni or Multi, it would only start if someone is there to receive it.
mkouba
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the #7097 epic. It re-implement the reactive support of Qute to use Mutiny instead of RX: