Add support for MutinyVerticle #7231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI issue is related, I will fix it later Today. |
cescoffier
force-pushed
the
features/vertx-mutiny-verticle
branch
from
ec3b4c3
to
43037d6
Compare
|
The issue should be fixed. |
cescoffier
force-pushed
the
features/vertx-mutiny-verticle
branch
from
43037d6
to
085d095
Compare
|
Rebased to see if the CI is happier now... |
mkouba
reviewed
Feb 19, 2020
mkouba
reviewed
Feb 19, 2020
cescoffier
force-pushed
the
features/vertx-mutiny-verticle
branch
3 times, most recently
from
7accdae
to
a4a7c9a
Compare
|
Yet another rebase to see if the CI is happy now... |
|
@mkouba Should be ok now. |
mkouba
approved these changes
Feb 20, 2020
Mutiny Verticle is a variant of Verticle using the Mutiny API.
Also add a test verifying that verticle instances can be beans.
cescoffier
force-pushed
the
features/vertx-mutiny-verticle
branch
from
a4a7c9a
to
8755db2
Compare
gsmet
approved these changes
Feb 20, 2020
gsmet
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add support for
MutinyVerticle- a type of verticle (Vert.x components) using the Mutiny API.This PR contains the feature, the documentation, and tests.