Fix elytron-security performance issue due to missing bean scope #8780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DefaultRoleDecoder has no CDI scope so it is insantiated for each request.
As it reads a propety at initialization time, this is very costly.
Adding
@ApplicationScoped
annotation to it lower the cost of security in one of my profile from 5.7% of frames to 1.3%All other elytron security related beans are
@ApplicationScoped
and reading the code this should be safe.