Make sure dev mode uses correct TCCL #9069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure it would work for blocking routes. |
|
yea, I need something for the blocking pool as well. We don't want to restore it because the original TCCL is wrong, vert.x survives dev mode restart, but the TCCL of the thread stays as the original. The threads should have this TCCL as the correct one, the original one basically represents a ClassLoader leak. |
stuartwdouglas
force-pushed
the
dev-mode-tccl
branch
from
57bc0ec
to
a49508a
Compare
boring-cyborg
bot
added
the
area/devtools
|
I have updated this approach to instead do a best effort TCCL clean on restart. |
|
It does not seem to work well (see CI log). We may have to wait for the completion of all the tasks you enqueue in the pools (both worker and event loops). |
stuartwdouglas
force-pushed
the
dev-mode-tccl
branch
2 times, most recently
from
44011dd
to
65129d7
Compare
stuartwdouglas
force-pushed
the
dev-mode-tccl
branch
from
65129d7
to
ab072e9
Compare
gsmet
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.