-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cloud Functions http bindings #9645
Google Cloud Functions http bindings #9645
Conversation
/cc @patriot1burke |
Did you get past the classloader issues? |
@patriot1burke yes, I use the Function classloader instead of the default one and everything works: https://github.com/quarkusio/quarkus/pull/9645/files#diff-56d25329b213eb7e0ccd2fd13ed6db5bR47 I wait for Stuart blessing on this ... |
34f224e
to
b5b9e34
Compare
b5b9e34
to
9608226
Compare
I have one question Loic, how do you bind their notion of background function https://github.com/GoogleCloudPlatform/functions-framework-java#quickstart-create-a-background-function That probably warrants an explanation in the guide. |
@emmanuelbernard currently only via Funqy: #9655 I openned the PR yesterday. But checking what we did for Amazon Lambda maybe I also need a dedicated extension for this.
I plan to add links to each other inside the two documentations later. |
@patriot1burke I had a chat with Stuart in Zulip and he confirm that, beside being strange that we need it, the workaround I use for the classloader issue is OK. |
9608226
to
b6cdffd
Compare
On Fri, May 29, 2020 at 4:37 AM Loïc Mathieu ***@***.***> wrote:
@emmanuelbernard <https://github.com/emmanuelbernard> currently only via
Funqy: #9655 <#9655> I openned
the PR yesterday.
But checking what we did for Amazon Lambda maybe I also need a dedicated
extension for this.
- google-cloud-functions-http => Bind an HTTP Function to RESTEasy,
Vert.x Web or Undertwo
- funqy-google-cloud-function => Bind HTTP Function and Background
Function to Funqy (cross platform function)
Why do you need a separate funqy HTTP binding for GCF?
- *New extension* => Allow calling directly HTTP Function and
Background Function (couple with Google Cloud Function API)
I plan to add links to each other inside the two documentations later.
For this, this is using GCF APIs that become Quarkus Arc components?
|
It's not funqy-http, it's a way to use funqy for GCF for both HttpFunction and BackgroundFunction. You can have a look at what it looks like in #9655.
I saw what you did for amazon-lambda, I currently experimenting for GCF, more on this when I ends up with something that works ;) |
b6cdffd
to
4caece6
Compare
@patriot1burke I refactory the netty code based on what you did for #9717 |
4caece6
to
a34a753
Compare
@patriot1burke do you know when you will have time to review this one ? I'll like to provides some sypport for Google Cloud Functions in 1.6 if possible and would prefere doing it at the begining of the dev cycle ... |
...-functions-http/runtime/src/main/java/io/quarkus/gcp/functions/http/QuarkusHttpFunction.java
Outdated
Show resolved
Hide resolved
a34a753
to
042d048
Compare
Google Cloud Functions http bindings to RESTEasy, Undertow and Vert.x Web.
Fixes #9267