Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Functions http bindings #9645

Merged

Conversation

loicmathieu
Copy link
Contributor

Google Cloud Functions http bindings to RESTEasy, Undertow and Vert.x Web.
Fixes #9267

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/documentation labels May 27, 2020
@loicmathieu
Copy link
Contributor Author

/cc @patriot1burke

@patriot1burke
Copy link
Contributor

Did you get past the classloader issues?

@loicmathieu
Copy link
Contributor Author

@patriot1burke yes, I use the Function classloader instead of the default one and everything works: https://github.com/quarkusio/quarkus/pull/9645/files#diff-56d25329b213eb7e0ccd2fd13ed6db5bR47

I wait for Stuart blessing on this ...

@loicmathieu loicmathieu force-pushed the gcp/cloud-function-http-bindings branch from 34f224e to b5b9e34 Compare May 28, 2020 11:17
@boring-cyborg boring-cyborg bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label May 28, 2020
@loicmathieu loicmathieu force-pushed the gcp/cloud-function-http-bindings branch from b5b9e34 to 9608226 Compare May 28, 2020 12:37
@emmanuelbernard
Copy link
Member

I have one question Loic, how do you bind their notion of background function https://github.com/GoogleCloudPlatform/functions-framework-java#quickstart-create-a-background-function

That probably warrants an explanation in the guide.

@loicmathieu
Copy link
Contributor Author

@emmanuelbernard currently only via Funqy: #9655 I openned the PR yesterday.

But checking what we did for Amazon Lambda maybe I also need a dedicated extension for this.

  • google-cloud-functions-http => Bind an HTTP Function to RESTEasy, Vert.x Web or Undertwo
  • funqy-google-cloud-function => Bind HTTP Function and Background Function to Funqy (cross platform function)
  • New extension => Allow calling directly HTTP Function and Background Function (couple with Google Cloud Function API)

I plan to add links to each other inside the two documentations later.

@loicmathieu
Copy link
Contributor Author

@patriot1burke I had a chat with Stuart in Zulip and he confirm that, beside being strange that we need it, the workaround I use for the classloader issue is OK.

@loicmathieu loicmathieu force-pushed the gcp/cloud-function-http-bindings branch from 9608226 to b6cdffd Compare May 29, 2020 10:06
@patriot1burke
Copy link
Contributor

patriot1burke commented May 29, 2020 via email

@loicmathieu
Copy link
Contributor Author

@patriot1burke

Why do you need a separate funqy HTTP binding for GCF?

It's not funqy-http, it's a way to use funqy for GCF for both HttpFunction and BackgroundFunction. You can have a look at what it looks like in #9655.

For this, this is using GCF APIs that become Quarkus Arc components?

I saw what you did for amazon-lambda, I currently experimenting for GCF, more on this when I ends up with something that works ;)

@loicmathieu loicmathieu force-pushed the gcp/cloud-function-http-bindings branch from b6cdffd to 4caece6 Compare June 4, 2020 13:37
@loicmathieu
Copy link
Contributor Author

@patriot1burke I refactory the netty code based on what you did for #9717

@loicmathieu loicmathieu force-pushed the gcp/cloud-function-http-bindings branch from 4caece6 to a34a753 Compare June 8, 2020 11:01
@loicmathieu
Copy link
Contributor Author

@patriot1burke do you know when you will have time to review this one ? I'll like to provides some sypport for Google Cloud Functions in 1.6 if possible and would prefere doing it at the begining of the dev cycle ...

@loicmathieu loicmathieu force-pushed the gcp/cloud-function-http-bindings branch from a34a753 to 042d048 Compare June 9, 2020 07:26
@patriot1burke patriot1burke merged commit 4618401 into quarkusio:master Jun 9, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 10, 2020
@loicmathieu loicmathieu deleted the gcp/cloud-function-http-bindings branch June 26, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure release/noteworthy-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Function support
4 participants