Two suggestion improvements to auto scroll #13

Closed
rfgamaral opened this Issue Jan 21, 2013 · 13 comments

Comments

Projects
None yet
2 participants
Contributor

rfgamaral commented Jan 21, 2013

I have 2 suggestions to improve auto scroll:

  1. When first launching ADBView with auto scroll enabled, the whole thing be "jumpy" because it will be loading the log from the device and then jumping to the newest entries, until it loads the whole log. So, my suggestions is to first load the whole log when launching ADBView and when finished, jump to the bottom.

  2. I love auto-scroll, it can be really useful. But sometimes, we need to manually scroll and look for stuff. It would be great that if we manually scroll (either with keys, scroll bars or scroll wheel), the auto scroll pauses and only resumes when we manually scroll down to the bottom.

I don't know if it's possible but for my second suggestion, it would be even better if the pause/resume behavior was changed by an on-screen button/checkbox or something.

Owner

quarnster commented Jan 21, 2013

1, Good Idea, I'll look into this.

2, Not sure if it's possible to detect whether the user is scrolling or not, I'll try some things out and we'll see. Currently the setting is never re-read but if it was a key binding to toggle the setting or an item in goto anything to toggle it would be possible. I'll look into this.

@quarnster quarnster added a commit that referenced this issue Jan 29, 2013

@quarnster quarnster Auto scroll improvements. #13 16271f7
Owner

quarnster commented Jan 29, 2013

I think I've got both of these working now. Could you give it a go and see if it's working as expected for you? Cheers

Contributor

rfgamaral commented Jan 30, 2013

I'm not able to properly test it as #15 broke compatibility with ST2.

Owner

quarnster commented Jan 30, 2013

What specifically isn't working for you? It's working here for me with ST2.

Contributor

rfgamaral commented Feb 1, 2013

I'm not sure what happens... Some Windows command prompts popup and quickly disappear but no tab with the the ADB logcat is opened on ST2. I know the problem is on #15 cause I tested commit by commit and it failed on that on, #14 works just fine.

Owner

quarnster commented Feb 1, 2013

Is there anything written in the python console?

Contributor

rfgamaral commented Feb 2, 2013

I'm not sure how I see that...

Owner

quarnster commented Feb 2, 2013

It's in the menu item "View -> Show Console"

Contributor

rfgamaral commented Feb 4, 2013

Sorry for the delay...

Here, I got this error on the console:

Traceback (most recent call last):
  File ".\sublime_plugin.py", line 339, in run_
  File ".\adbview.py", line 429, in run
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 3059: ordinal not in range(128)

@quarnster quarnster added a commit that referenced this issue Feb 4, 2013

@quarnster quarnster Possible fix for #13 43aabc5
Owner

quarnster commented Feb 4, 2013

Could you try and see if 43aabc5 makes it work?

Contributor

rfgamaral commented Feb 4, 2013

Now it doesn't show up and I can't even launch it...

Owner

quarnster commented Feb 4, 2013

Sorry, I had managed to use a reserved python keyword. Please try again now with the latest change 5c38e0c

Contributor

rfgamaral commented Feb 7, 2013

Everything is working perfectly now :)

Thanks.

quarnster closed this Feb 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment