Change default logcat format to threadtime #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjx20
requested changes
Jan 12, 2017
| @@ -13,7 +13,7 @@ | |||
| "adb_snap_lines": 5, | |||
|
|
|||
| // Max number of lines in the adb logcat buffer | |||
| "adb_maxlines": 20000, | |||
| "adb_maxlines": 200000, | |||
There was a problem hiding this comment.
200000 is too much. In my experience, ADBView can barely handle such a number of lines. So I suggest to change this value to 100000.
| @@ -1,7 +1,7 @@ | |||
| [ | |||
| { "caption": "-", "id": "adb" }, | |||
| { "command": "adb_filter_by_process_id", "caption": "ADB Filter by Process ID" }, | |||
| { "command": "adb_filter_by_process_name", "caption": "ADB Filter by Process Name" }, | |||
| { "command": "adb_filter_by_thread_id", "caption": "ADB Filter By Thread ID" }, | |||
There was a problem hiding this comment.
The "filter by process name" feature still makes sense. Could you just add a new command for "filter by thread id", instead of replacing an existing one? Also, could you update README.md for the new added command as well?
| <dict> | ||
| <key>name</key> | ||
| <string>Android Debug Bridge</string> | ||
| <string>Android Debug Bridge Full</string> |
There was a problem hiding this comment.
There is no need to change the name.
zjx20
requested changes
Jan 13, 2017
| if match != None: | ||
| set_filter(self.view, "^\d+\-\d+ [\d\:\.]* +\d+ +\d+ %s:" % match.group(1)) | ||
| else: | ||
| sublime.error_message("Couldn't extract thread id") |
zjx20
approved these changes
Jan 16, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
01-12 14:41:02.931 13186 13211 D AccountTypeManager: Registering 1 extension packages
The thread id may be useful for developers who cares about multiple-thread runtime condition.