Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

run_cmd can take list of commands as input #32

Merged
merged 1 commit into from Oct 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

trsaunders commented Oct 14, 2012

patch to allow run_cmd to also take a list of commands. It allows configs such as:

        "sublimegdb_exec_cmd" : [
            "target remote localhost:3333",
            "monitor reset halt",
            "load build/ch.elf",
            "monitor reset halt",
            "continue"
        ]

Each command will have its own timeout. Maybe the timeout should apply to the whole set of commands? I'm not sure of the best behaviour

quarnster added a commit that referenced this pull request Oct 14, 2012

Merge pull request #32 from trsaunders/master
run_cmd can take list of commands as input

@quarnster quarnster merged commit a06b616 into quarnster:master Oct 14, 2012

Owner

quarnster commented Oct 14, 2012

I guess the largest problem is if it fails for some reason and then you are stuck with x commands times y seconds of timeout where Sublime Text 2's main thread is hung, but I consider that to be a separate problem not really related to this change. I'll open up a new issue tracking that.

Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment