From bf95341e85fd0ae2136f6d19902b62842c5a0c2c Mon Sep 17 00:00:00 2001 From: Christophe Dervieux Date: Fri, 4 Oct 2024 14:17:40 +0200 Subject: [PATCH 1/4] Revert "disable test temporarily" This reverts commit 9d00acae2607c1d0fae479b0b8f830145454b207. --- tests/docs/run/test-stdlib.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/docs/run/test-stdlib.ts b/tests/docs/run/test-stdlib.ts index 0e4f0bb2af2..1c4c85ea7ce 100644 --- a/tests/docs/run/test-stdlib.ts +++ b/tests/docs/run/test-stdlib.ts @@ -1,2 +1 @@ -// Temporarily turn this off. -// import { readLines } from "stdlib/io"; +import { readLines } from "stdlib/io"; From de7ad24a20f61f50f1e3e8116137ae929bca75f6 Mon Sep 17 00:00:00 2001 From: Christophe Dervieux Date: Fri, 4 Oct 2024 17:02:25 +0200 Subject: [PATCH 2/4] Don't use `--cached-only` with quarto run in dev mode. --- src/core/run/deno.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/run/deno.ts b/src/core/run/deno.ts index 96111b4de6b..2f3af8fdd99 100644 --- a/src/core/run/deno.ts +++ b/src/core/run/deno.ts @@ -12,6 +12,7 @@ import { architectureToolsPath, resourcePath } from "../resources.ts"; import { RunHandler, RunHandlerOptions } from "./types.ts"; import { removeIfExists } from "../path.ts"; import { copyTo } from "../copy.ts"; +import { quartoConfig } from "../quarto.ts"; export const denoRunHandler: RunHandler = { canHandle: (script: string) => { @@ -42,7 +43,8 @@ export const denoRunHandler: RunHandler = { "run", "--import-map", importMap, - "--cached-only", + // --cached-only can only be used in bundles as vendoring is not done anymore in dev mode + ...(quartoConfig.isDebug() ? [] : ["--cached-only"]), "--allow-all", "--unstable-kv", "--unstable-ffi", From 5c38d77c240f3eb2a6ebf5239a31cf7c7ea9be07 Mon Sep 17 00:00:00 2001 From: Christophe Dervieux Date: Fri, 4 Oct 2024 17:03:06 +0200 Subject: [PATCH 3/4] run the test on windows too. --- tests/smoke/run/stdlib-run-version.test.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/smoke/run/stdlib-run-version.test.ts b/tests/smoke/run/stdlib-run-version.test.ts index 16dbcda355c..1c7f4dbb90a 100644 --- a/tests/smoke/run/stdlib-run-version.test.ts +++ b/tests/smoke/run/stdlib-run-version.test.ts @@ -19,6 +19,4 @@ unitTest("stdlib-run-version", async () => { }); console.log({result}) assert(result.success); -}, { - ignore: Deno.build.os == "windows", }); From 5e4f37a1ea7d4afaba8548e9d9ef8b68d83eb957 Mon Sep 17 00:00:00 2001 From: Christophe Dervieux Date: Fri, 4 Oct 2024 20:31:44 +0200 Subject: [PATCH 4/4] Revert "run the test on windows too." This reverts commit 5c38d77c240f3eb2a6ebf5239a31cf7c7ea9be07. --- tests/smoke/run/stdlib-run-version.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/smoke/run/stdlib-run-version.test.ts b/tests/smoke/run/stdlib-run-version.test.ts index 1c7f4dbb90a..16dbcda355c 100644 --- a/tests/smoke/run/stdlib-run-version.test.ts +++ b/tests/smoke/run/stdlib-run-version.test.ts @@ -19,4 +19,6 @@ unitTest("stdlib-run-version", async () => { }); console.log({result}) assert(result.success); +}, { + ignore: Deno.build.os == "windows", });