Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Mar 22, 2023

due to current limitation of Pandoc jgm/pandoc#8709

closes #4917

I used the tweak in resolveFormat() as we do it elsewhere, but we also do some tweaks like that in formatExtras() (see revealsj format) but it seemed to late to check pandoc[kToc]

This could be improved by making pandocFormat() not add an extension if already there.

cc @dragonstyle

For 1.3 or 1.4 - I just wanted to deal with it now. 😅

@cderv cderv requested a review from dragonstyle March 22, 2023 13:34
@cderv cderv added the needs-discussion Issues that require a team-wide discussion before proceeding further label Mar 23, 2023
@cderv cderv requested a review from jjallaire March 23, 2023 15:58
@cderv cderv added this to the v1.4 milestone Mar 23, 2023
@cderv cderv removed the needs-discussion Issues that require a team-wide discussion before proceeding further label Mar 23, 2023
@cderv
Copy link
Collaborator Author

cderv commented Mar 24, 2023

I rebased onto main which includes #4937 but the issue still remains 🤔

@cderv
Copy link
Collaborator Author

cderv commented Mar 27, 2023

@cscheid your fix in #4957 for circular dependency solved the issue in the PR with bundling. Thanks !

@dragonstyle dragonstyle merged commit de94b0d into main May 4, 2023
@dragonstyle dragonstyle deleted the fix/gfm-toc branch May 4, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toc: true with gfm does not produce valid link for Github when special char in headers

3 participants