bug/giscus-dark-toggle #5020
Merged
bug/giscus-dark-toggle #5020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
commented
Mar 29, 2023
ghost
commented
Mar 29, 2023
ghost
commented
Mar 29, 2023
ghost
commented
Mar 29, 2023
rich-iannone
approved these changes
Apr 14, 2023
Collaborator
rich-iannone
left a comment
rich-iannone
left a comment
There was a problem hiding this comment.
This looks good and the included tests cover the changes made. Minor nit (take it or leave it) is to include a space after using if (in two instances).
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
dragonstyle
reviewed
Apr 27, 2023
Collaborator
|
One tiny lint and otherwise looks great! Nice improvement to theming! |
dragonstyle
approved these changes
Apr 27, 2023
ghost
commented
May 2, 2023
added 2 commits
May 3, 2023 08:56
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#closes #4820