diff --git a/news/changelog-1.5.md b/news/changelog-1.5.md index 6d89abdf7e3..e15139682d0 100644 --- a/news/changelog-1.5.md +++ b/news/changelog-1.5.md @@ -4,6 +4,10 @@ All changes included in 1.5: - ([#8118](https://github.com/quarto-dev/quarto-cli/issues/8118)): Add support for `body-classes` to add classes to the document body. +## Website + +- ([#7318](https://github.com/quarto-dev/quarto-cli/issues/7318)): Don't improperly overwrite page titles + ## Other Fixes - ([#8119](https://github.com/quarto-dev/quarto-cli/issues/8119)): More intelligently detect when ejs templates are modified during development, improving quality of life during preview. diff --git a/src/project/types/website/website-meta.ts b/src/project/types/website/website-meta.ts index c71a1c8af47..418303bdc8a 100644 --- a/src/project/types/website/website-meta.ts +++ b/src/project/types/website/website-meta.ts @@ -432,10 +432,12 @@ const kOgTitle = "quarto-ogcardtitle"; const kOgDesc = "quarto-ogcardddesc"; const kMetaSideNameId = "quarto-metasitename"; function metaMarkdownPipeline(format: Format, extras: FormatExtras) { + const resolvedTitle = computePageTitle(format); + const titleMetaHandler = { getUnrendered() { const inlines: Record = {}; - const resolvedTitle = computePageTitle(format); + if (resolvedTitle !== undefined) { inlines[kMetaTitleId] = resolvedTitle; } @@ -455,7 +457,7 @@ function metaMarkdownPipeline(format: Format, extras: FormatExtras) { const el = doc.querySelector( `head title`, ); - if (el) { + if (el && el.innerText === resolvedTitle) { if (format.pandoc[kNumberSections] === false) { // Remove chapter numbers if not numbered const numberEl = renderedEl.querySelector("span.chapter-number");