Skip to content

Add custom domain set up to Github Pages #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cwickham merged 4 commits into from
Mar 13, 2025
Merged

Add custom domain set up to Github Pages #1583

cwickham merged 4 commits into from
Mar 13, 2025

Conversation

@cwickham
Copy link
Collaborator

@cwickham cwickham commented Mar 11, 2025 •
edited
Loading

Closes quarto-dev/quarto-cli#4941

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

🚀 Deployed on https://deploy-preview-1583.quarto.org

@github-actions github-actions bot temporarily deployed to pull request March 11, 2025 20:09 Inactive
@cwickham cwickham marked this pull request as ready for review March 11, 2025 20:13
@cwickham
Copy link
Collaborator Author

cwickham commented Mar 11, 2025

@mcanouil , I'm not convinced I followed the whole thread in the related issues and discussion. Does this cover it? It seems like the same instructions work regardless of method (docs/, quarto publish gh-pages, or GitHub Action). Is that right?

@cwickham cwickham requested a review from cderv March 11, 2025 20:15
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

🚀 Deployed on https://deploy-preview-1583.quarto.org

@github-actions github-actions bot temporarily deployed to pull request March 11, 2025 20:17 Inactive
@mcanouil
Copy link
Contributor

mcanouil commented Mar 11, 2025

I think that covers the current resources detection from Quarto (via quarto render).
So it should cover manual deployment and deployment via the publish command.

cderv
cderv approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks a lot !!

@cwickham cwickham merged commit 6e3ca3e into main Mar 13, 2025
4 checks passed
@cwickham cwickham deleted the issue/4941 branch March 13, 2025 19:03
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
@cwickham @github-actions
Add custom domain set up to Github Pages (#1583)
908a42a 
* Custom domain details

* Add note about recognized files

(cherry picked from commit 6e3ca3e)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

Successfully created backport PR for prerelease:

@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Merged
cwickham added a commit that referenced this pull request Mar 13, 2025
@github-actions @cwickham
Add custom domain set up to Github Pages (#1583) (#1584)
bd3549f 
* Custom domain details

* Add note about recognized files

(cherry picked from commit 6e3ca3e)

Co-authored-by: Charlotte Wickham <charlotte.wickham@posit.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cderv cderv cderv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document how to setup custom domain on Github Pages when using quarto publish gh-pages

4 participants

@cwickham @mcanouil @cderv