Skip to content

Conversation

@mcanouil
Copy link
Contributor

@mcanouil mcanouil commented Jun 1, 2025

This pull request enhances the docs/troubleshooting/index.qmd file by adding platform-specific instructions for setting the QUARTO_LOG_LEVEL environment variable.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except maybe... Problem with the PR title and commit message? 😅

On PowerShell:

```powershell
$env:QUARTO_LOG_LEVEL = "DEBUG"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the space too like on linux

Suggested change
$env:QUARTO_LOG_LEVEL = "DEBUG"
$env:QUARTO_LOG_LEVEL="DEBUG"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied from the QUARTO_PRINT_STACK section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks. I'll change both. I think we should avoid space where we can.

@cderv
Copy link
Collaborator

cderv commented Jun 2, 2025

/deploy-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1678.quarto.org

🔄 Modified Documents

@mcanouil
Copy link
Contributor Author

mcanouil commented Jun 2, 2025

Problem with the PR title and commit message?

I did not get what you meant here.

@cderv
Copy link
Collaborator

cderv commented Jun 2, 2025

I did not get what you meant here.

Sorry then - I did not get the direct link between fix: use code blocks for copy button and the PR content which is not fixing something about copy button missing but adding tabsets to get more precise about how to set environment on Linux and Windows.

I guess I am used to see you use very specific commit message with prefix - so it surprised me 😅

@mcanouil
Copy link
Contributor Author

mcanouil commented Jun 2, 2025

Oh I see.
Adding the code block does trigger the copy button which was not there for the inline code.
So I was fixing the lack of copy button by adding the code blocks^^

I added the tabset, because why not also provide the Windows version.

@cderv cderv merged commit 64388d0 into quarto-dev:main Jun 2, 2025
3 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Successfully created backport PR for prerelease:

@cderv
Copy link
Collaborator

cderv commented Jun 2, 2025

I understand now. I am used to descriptive PR title and commit message, and so it surprised me here as the main thing to me was adding tabsets and code blocks and not just fixing something :)

@mcanouil mcanouil deleted the patch-4 branch June 2, 2025 15:47
@mcanouil
Copy link
Contributor Author

mcanouil commented Jun 2, 2025

it was an issue to me when I tried to copy it^^
Tabset was only to style the fix.😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants