Skip to content

Conversation

@mcanouil
Copy link
Contributor

@mcanouil mcanouil commented Dec 8, 2025

@cderv
Copy link
Collaborator

cderv commented Dec 8, 2025

/deploy-preview

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1837.quarto.org

🔄 Modified Documents

@cderv cderv merged commit 73360cf into quarto-dev:main Dec 8, 2025
3 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Successfully created backport PR for prerelease:

@cderv
Copy link
Collaborator

cderv commented Dec 8, 2025

😭 I did not pay attention you did the PR on main...

Please be sure to do it on prerelease branch when for a "next version" feature.

I'll think of something to avoid this problem in the future.

cderv added a commit that referenced this pull request Dec 8, 2025
This reverts commit 73360cf, reversing
changes made to 978ac7b.
@cderv
Copy link
Collaborator

cderv commented Dec 8, 2025

Reverted on main with d367b05 and merged on prerelease in #1838

@mcanouil
Copy link
Contributor Author

mcanouil commented Dec 8, 2025

😭 I did not pay attention you did the PR on main...

Please be sure to do it on prerelease branch when for a "next version" feature.

I completely forgot about this and did not pay attention ... Sorry.

I'll think of something to avoid this problem in the future.

Maybe something that better advertise (a comment?) that the target branch is "main" or "pre-release" to both author and reviewer.

@mcanouil mcanouil deleted the patch-9 branch December 8, 2025 13:43
@cderv
Copy link
Collaborator

cderv commented Dec 8, 2025

Now I'll pay attention for sure. We don't get that much contribution and usually we do it right. I guess now you now. This seems hard to automate something as probably hard to know if this is a PR for a new feature or not.

Anyhow, my fault as I merged, I should have checked. If this happens again, I'll think of an automation

@mcanouil
Copy link
Contributor Author

mcanouil commented Dec 8, 2025

I knew but forgot as I usually don't contribute new release stuff.
Now, I won't forget^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants