From 4aa5c03f64f82784fd2053268095bb2aa8406ad6 Mon Sep 17 00:00:00 2001 From: elliot Date: Wed, 24 Sep 2025 16:34:43 -0400 Subject: [PATCH] Fix cell executor selection logic so bash cell execution works --- apps/vscode/src/host/executors.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/vscode/src/host/executors.ts b/apps/vscode/src/host/executors.ts index fddfe2b5..f9da27af 100644 --- a/apps/vscode/src/host/executors.ts +++ b/apps/vscode/src/host/executors.ts @@ -148,7 +148,11 @@ const csharpCellExecutor: VSCodeCellExecutor = { const bashCellExecutor: VSCodeCellExecutor = { language: "bash", execute: async (blocks: string[]) => { - const terminal = window.activeTerminal || window.createTerminal(); + // todo: this should probably check that the terminal isn't an interactive terminal for languages + // other than R as well... + const terminal = window.activeTerminal && window.activeTerminal?.name !== 'R Interactive' ? + window.activeTerminal : window.createTerminal(); + terminal.show(); terminal.sendText(blocks.join("\n")); }, @@ -278,7 +282,7 @@ export async function ensureRequiredExtension( } } } else { - return false; + return true; } }