Skip to content

feat: Add n-show-depth#41

Merged
gadenbuie merged 2 commits into
mainfrom
feat/n-show-depth
Jan 22, 2025
Merged

feat: Add n-show-depth#41
gadenbuie merged 2 commits into
mainfrom
feat/n-show-depth

Conversation

@gadenbuie
Copy link
Copy Markdown
Collaborator

@gadenbuie gadenbuie commented Jan 22, 2025

Fixes #15

Adds an n-show-depth option that limits the initial depth of the reply tree.

image

@gadenbuie gadenbuie merged commit 976c2fa into main Jan 22, 2025
Comment thread README.md
- `n-show-init`: Number of top-level comments to show initially (default: `3`)
- `n-show-more`: Number of replies to reveal when the user clicks on the "Show more" button (default: `2`)
- `header`: Whether or not to add a level-2 header above the comments. Use `header="true"` as a shortcut for `header="Comments"` (default: `false`).
`mute-patterns`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we place this inside of a table for consistency? (I agree the bullet-point list didn't look good here w/ more options.)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good point. Though I'd rather cut out everything but installation and basic usage from the README. I don't like updating things in two places (too easy to forget one of them). As long as the README gives a good sense of what the extension does, I'd rather push people to the website for more detailed documentation like configuration, etc.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gadenbuie not a fan either. Majority of the README.md should be matriculated over to the main website. I'll handle this clean up if you want.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I took a quick pass at it in #42. Mostly I just cut out content that I know we already have on the website. Feel free to add to that PR!

@gadenbuie gadenbuie deleted the feat/n-show-depth branch January 22, 2025 03:38
@gadenbuie gadenbuie mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit nested comment levels

2 participants