New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move trailing comments to enum #527

Merged

benfdking merged 1 commit into main from moving_to_trailing_comments_to_enum

Jul 18, 2024

Collaborator

benfdking commented Jul 18, 2024

No description provided.


          chore: move trailing comments to enum

774712f

benfdking force-pushed the moving_to_trailing_comments_to_enum branch from 9513748 to 774712f Compare

July 18, 2024 14:23

github-actions bot commented Jul 18, 2024

Benchmark for `59ffb08`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	141.7±1.79µs	142.1±2.77µs	+0.28%
fix_complex_query	13.2±0.10ms	13.0±0.12ms	-1.52%
parse_complex_query	4.3±0.07µs	4.2±0.03µs	-2.33%
parse_expression_recursion	7.4±0.10µs	7.2±0.09µs	-2.70%
parse_simple_query	1381.6±31.12ns	1401.2±110.04ns	+1.42%

github-actions bot commented Jul 18, 2024

Benchmark for `9a4ef4d`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	143.6±1.10µs	140.8±2.93µs	-1.95%
fix_complex_query	12.7±0.08ms	12.6±0.23ms	-0.79%
parse_complex_query	4.2±0.06µs	4.2±0.03µs	0.00%
parse_expression_recursion	7.2±0.10µs	7.2±0.26µs	0.00%
parse_simple_query	1404.8±24.98ns	1378.1±77.83ns	-1.90%

benfdking added this pull request to the merge queue

Merged via the queue into main with commit 18f88cc

11 of 12 checks passed

benfdking deleted the moving_to_trailing_comments_to_enum branch

July 18, 2024 14:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet