Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary alloc #532

Merged
merged 2 commits into from
Jul 19, 2024
Merged

refactor: remove unnecessary alloc #532

merged 2 commits into from
Jul 19, 2024

Conversation

gvozdvmozgu
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

Benchmark for 90fa2f7

Click to view benchmark
Test Base PR %
DepthMap::from_parent 147.4±1.47µs 146.7±3.22µs -0.47%
fix_complex_query 12.6±0.17ms 14.9±0.18ms +18.25%
parse_complex_query 4.3±0.06µs 4.2±0.04µs -2.33%
parse_expression_recursion 7.3±0.11µs 7.1±0.08µs -2.74%
parse_simple_query 1435.8±28.76ns 1399.5±101.31ns -2.53%

@gvozdvmozgu
refactor: updated configured_types to iterate over `block_class_typ…
58c7138 
…es` and check against `self.config_types` for better filtering logic
@github-actions GitHub Actions
Copy link

Benchmark for 90fa2f7

Click to view benchmark
Test Base PR %
DepthMap::from_parent 145.9±5.47µs 148.5±2.59µs +1.78%
fix_complex_query 12.6±0.21ms 14.6±0.32ms +15.87%
parse_complex_query 4.3±0.07µs 4.3±0.07µs 0.00%
parse_expression_recursion 7.3±0.12µs 7.2±0.10µs -1.37%
parse_simple_query 1416.6±25.27ns 1372.3±51.06ns -3.13%

@github-actions GitHub Actions
Copy link

Benchmark for 2cc6e62

Click to view benchmark
Test Base PR %
DepthMap::from_parent 146.9±1.87µs 145.2±2.20µs -1.16%
fix_complex_query 12.8±0.12ms 11.6±0.17ms -9.38%
parse_complex_query 4.3±0.04µs 4.2±0.06µs -2.33%
parse_expression_recursion 7.2±0.04µs 7.2±0.13µs 0.00%
parse_simple_query 1413.6±36.42ns 1421.3±76.71ns +0.54%

@gvozdvmozgu gvozdvmozgu requested a review from benfdking July 19, 2024 13:07
@benfdking benfdking added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit a31aba4 Jul 19, 2024
11 of 12 checks passed
@benfdking benfdking deleted the remove-unnecessary-alloc branch July 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfdking benfdking benfdking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvozdvmozgu @benfdking