Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rework type of segments #534

Merged
merged 5 commits into from
Jul 20, 2024
Merged

refactor: rework type of segments #534

merged 5 commits into from
Jul 20, 2024

Conversation

gvozdvmozgu
Copy link
Collaborator

No description provided.

Copy link

Benchmark for 6047e54

Click to view benchmark
Test Base PR %
DepthMap::from_parent 148.2±1.74µs 142.1±2.97µs -4.12%
fix_complex_query 11.5±0.05ms 11.3±0.05ms -1.74%
parse_complex_query 4.3±0.06µs 4.2±0.08µs -2.33%
parse_expression_recursion 7.3±0.05µs 7.2±0.05µs -1.37%
parse_simple_query 1412.9±16.07ns 1421.3±77.27ns +0.59%

Copy link

Benchmark for 91857fd

Click to view benchmark
Test Base PR %
DepthMap::from_parent 144.8±2.61µs 138.6±2.31µs -4.28%
fix_complex_query 11.5±0.08ms 10.9±0.56ms -5.22%
parse_complex_query 4.3±0.03µs 4.3±0.21µs 0.00%
parse_expression_recursion 7.1±0.06µs 7.2±0.13µs +1.41%
parse_simple_query 1403.9±29.62ns 1409.0±43.91ns +0.36%

Copy link

Benchmark for 1f7da4c

Click to view benchmark
Test Base PR %
DepthMap::from_parent 146.6±1.73µs 107.6±1.42µs -26.60%
fix_complex_query 11.5±0.17ms 8.3±0.12ms -27.83%
parse_complex_query 4.3±0.06µs 4.3±0.06µs 0.00%
parse_expression_recursion 7.2±0.08µs 7.2±0.05µs 0.00%
parse_simple_query 1377.4±32.52ns 1395.8±50.49ns +1.34%

@gvozdvmozgu gvozdvmozgu marked this pull request as ready for review July 20, 2024 02:33
@gvozdvmozgu gvozdvmozgu requested a review from benfdking July 20, 2024 02:33
Copy link

Benchmark for 7c3a8d3

Click to view benchmark
Test Base PR %
DepthMap::from_parent 146.7±1.28µs 103.7±1.28µs -29.31%
fix_complex_query 11.4±0.17ms 8.4±0.35ms -26.32%
parse_complex_query 4.3±0.07µs 4.3±0.08µs 0.00%
parse_expression_recursion 7.2±0.11µs 7.1±0.06µs -1.39%
parse_simple_query 1390.3±25.09ns 1350.3±22.83ns -2.88%

Copy link

Benchmark for 173c2f3

Click to view benchmark
Test Base PR %
DepthMap::from_parent 149.6±2.74µs 106.2±0.71µs -29.01%
fix_complex_query 11.5±0.07ms 8.3±0.13ms -27.83%
parse_complex_query 4.3±0.23µs 4.2±0.07µs -2.33%
parse_expression_recursion 7.2±0.11µs 7.2±0.35µs 0.00%
parse_simple_query 1429.0±62.08ns 1359.4±57.55ns -4.87%

Copy link

Benchmark for b0527e9

Click to view benchmark
Test Base PR %
DepthMap::from_parent 145.4±2.41µs 106.3±3.92µs -26.89%
fix_complex_query 11.5±0.12ms 8.4±0.24ms -26.96%
parse_complex_query 4.2±0.04µs 4.2±0.02µs 0.00%
parse_expression_recursion 7.2±0.14µs 7.0±0.09µs -2.78%
parse_simple_query 1393.7±21.38ns 1343.2±38.61ns -3.62%

@benfdking benfdking added this pull request to the merge queue Jul 20, 2024
Merged via the queue into main with commit a9783be Jul 20, 2024
12 checks passed
@benfdking benfdking deleted the rework_types branch July 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants