Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Discussion: Remove PDFjs #45

Open
hawkeye64 opened this issue Dec 30, 2019 · 2 comments
Open

Open Discussion: Remove PDFjs #45

hawkeye64 opened this issue Dec 30, 2019 · 2 comments
Labels

Comments

@hawkeye64
Copy link
Member

@hawkeye64 hawkeye64 commented Dec 30, 2019

I am considering to remove the PDFjs dependency and go back to just the HTML5 PDF Viewer (as it was originally). The latter is more light-weight, because it uses the internal PDF Viewer built into the browser. However, this excludes Electron/Capacitor/Cordova, etc. In which case, these platforms should use the PDFjs on their own, or an extension could be written to incorporate it.

Ever since the PDFjs dependency was added, this project has stalled out because of the issues with PDFjs.

Please voice your concerns and/or advice here.

@mesqueeb

This comment has been minimized.

Copy link
Contributor

@mesqueeb mesqueeb commented Jan 8, 2020

Maybe you can just split the library in qpdfviewer and qpdfviewer-universal where universal is the one that is capable with capacitor.

Or maybe you can split the library in qpdfviewer and qpdfviewer-light where light is the one that only has HTML5 support.

For me personally: Any place I need to show PDFs I need a solution for Capacitor as well at the same time.

@mesqueeb

This comment has been minimized.

Copy link
Contributor

@mesqueeb mesqueeb commented Jan 11, 2020

I just have a new project that will only be used in browsers, so I won't need the PDFjs dependency for that.
For some other Capacitor apps, I switched the logic to it opens PDFs inside an in-app-browser and therefor just uses the iOS browser PDF viewer. It works just as well really and it made it possible for me to remove the QPdfviewer dependency, making the app much lighter.

So I'd say: fork this repo and do one of these:

  • qpdfviewer______ and qpdfviewer-universal
  • qpdfviewer-light and qpdfviewer
  • qpdfviewer-light and qpdfviewer-universal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.