New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS import order different for "quasar dev" and "quasar build" #47

Open
tdamsma opened this Issue Oct 24, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@tdamsma

tdamsma commented Oct 24, 2017

I am having issues with the css import order when building the default app; Specifically material-icons.css has precedence over quasar-mat-css after building, but it's the other way around in dev mode.

I found similar report on the forum: http://forum.quasar-framework.org/topic/989/the-compact-css-generated-with-quasar-build-mat-quasar-does-not-match-to-the-quasar-mat-css-in-dev-environment

To reproduce:
quasar init and add a <q-fab color="primary" icon="add" direction="left"></q-fab> to the template.

Icon is centred after viewing with quasar dev, but after building with quasar build the icon is shifted up. Inspection of the generated css shows that the order for dev and build is different: 'material-icons.css' has precedence over 'quasar-mat-css' in build mode

Also switching off purifyCss doesn't help.

I have added a a repo demonstrating the issue here: https://github.com/tdamsma/quasar-css-import-bug

@omrihar

This comment has been minimized.

Show comment
Hide comment
@omrihar

omrihar Nov 10, 2017

I have the same problem. I encountered it when I couldn't understand why my icons are suddenly not centered. Thanks for catching this! @tdamsma did you find a workaround on how to compile this so it will work until the issue is solved?

omrihar commented Nov 10, 2017

I have the same problem. I encountered it when I couldn't understand why my icons are suddenly not centered. Thanks for catching this! @tdamsma did you find a workaround on how to compile this so it will work until the issue is solved?

@tdamsma

This comment has been minimized.

Show comment
Hide comment
@tdamsma

tdamsma Nov 10, 2017

tdamsma commented Nov 10, 2017

@pdanpdan

This comment has been minimized.

Show comment
Hide comment
@pdanpdan

pdanpdan Nov 13, 2017

Contributor

Can you please set purifyCSS: false in config/index.js and check if the problem persists?
Ah, sorry, I didn't read that you already tried it.

Contributor

pdanpdan commented Nov 13, 2017

Can you please set purifyCSS: false in config/index.js and check if the problem persists?
Ah, sorry, I didn't read that you already tried it.

@tdamsma

This comment has been minimized.

Show comment
Hide comment
@tdamsma

tdamsma Nov 13, 2017

@pdanpdan, can you perhaps clone the repo and check if you can reproduce the error? Want to be sure it is not just something with my local setup

tdamsma commented Nov 13, 2017

@pdanpdan, can you perhaps clone the repo and check if you can reproduce the error? Want to be sure it is not just something with my local setup

@pdanpdan

This comment has been minimized.

Show comment
Hide comment
@pdanpdan

pdanpdan Nov 13, 2017

Contributor

Ok, I found it on that repo.
It needs a reordering of imports in main.js.
You have a PR in the repo.

Contributor

pdanpdan commented Nov 13, 2017

Ok, I found it on that repo.
It needs a reordering of imports in main.js.
You have a PR in the repo.

@tdamsma

This comment has been minimized.

Show comment
Hide comment
@tdamsma

tdamsma Nov 13, 2017

@pdanpdan that solved it, thanks a lot! Will you also submit that PR for this repo? I think everyone can benefit from this.

tdamsma commented Nov 13, 2017

@pdanpdan that solved it, thanks a lot! Will you also submit that PR for this repo? I think everyone can benefit from this.

@pdanpdan

This comment has been minimized.

Show comment
Hide comment
@pdanpdan

pdanpdan Nov 13, 2017

Contributor

We'll have a new template soon, so it's no need.

Contributor

pdanpdan commented Nov 13, 2017

We'll have a new template soon, so it's no need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment