Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] QCollapsible add style for open item #2375

Closed
krugerpl opened this issue Aug 3, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@krugerpl
Copy link

commented Aug 3, 2018

QCollapsible should receive q-collapsible-opened class for open state not only when prop popup is present.
right now:

computed: {
classes () {
return {
'q-collapsible-opened': this.popup && this.showing,
'q-collapsible-closed': this.popup && !this.showing,
'q-collapsible-cursor-pointer': !this.iconToggle,
'q-item-dark': this.dark,
'q-item-separator': this.separator,
'q-item-inset-separator': this.insetSeparator,
disabled: this.disable
}
}
},

after fix:

computed: {
classes () {
return {
'q-collapsible-opened': this.showing,
'q-collapsible-closed': !this.showing,
'q-collapsible-cursor-pointer': !this.iconToggle,
'q-item-dark': this.dark,
'q-item-separator': this.separator,
'q-item-inset-separator': this.insetSeparator,
disabled: this.disable
}
}
},

@rstoenescu

This comment has been minimized.

Copy link
Member

commented Aug 6, 2018

Hi,

  1. q-collapsible-opened/closed is a class for popup-type collapsibles exclusively.
  2. Why do you need a class for this?
@krugerpl

This comment has been minimized.

Copy link
Author

commented Aug 7, 2018

I need add a style for opened item (change background color). I am using q-collapsible as accordion. I don't want popup effect. I just want to style opened item for visibility.

Maybe we can change styles for q-collapsible-opened/closed like this? ;

computed: {
classes () {
return {
'q-collapsible-popup-opened': this.popup && this.showing,
'q-collapsible-popup-closed': this.popup && !this.showing,
'q-collapsible-opened': this.showing,
'q-collapsible-closed': !this.showing,
'q-collapsible-cursor-pointer': !this.iconToggle,
'q-item-dark': this.dark,
'q-item-separator': this.separator,
'q-item-inset-separator': this.insetSeparator,
disabled: this.disable
}
}
},

Please look at this link.
https://vuetifyjs.com/en/components/expansion-panels

Vuetify panels have "v-expansion-panel__container--active" class added to normal items and v-expansion-panel--popout is added to parent element if popup mode is used.

@rstoenescu

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

'q-collapsible-opened/closed' it is. In future 0.17.7.

@rstoenescu rstoenescu closed this Aug 7, 2018

@krugerpl

This comment has been minimized.

Copy link
Author

commented Aug 7, 2018

Thank You Razvan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.