Hardcoded english in DataTable #284

Closed
caex opened this Issue Dec 27, 2016 · 2 comments

Projects

None yet

2 participants

@caex
caex commented Dec 27, 2016

Hello,

just integrated the DataTable component and it's great.
However one problem is the hardcoded english, unfortunately my WebApp is in french.

There are the culprits :
(DataTable.vue line 20)

static-label="Columns"

(lines 30-31)

{{ rowsSelected }} item<span v-show="rowsSelected > 1">s</span> selected.
  <button class="primary clear small" @click="clearSelection()">Clear</button>

(TablePagination.vue line 4)

Rows

Would be great if we could customize it through Props or Slots.

Or to have just one lang="en" prop and let the community build a language file for each language, with fallback to english 👍

Cheers

@rstoenescu
Collaborator

Yes, part of Internationalization #100 . Will soon be fixed.

@rstoenescu rstoenescu closed this Dec 27, 2016
@rstoenescu rstoenescu reopened this Dec 28, 2016
@rstoenescu
Collaborator

Internationalization as a whole might take a while, so adding config.labels to handle this.

@rstoenescu rstoenescu closed this Dec 28, 2016
@rstoenescu rstoenescu added this to the v0.12 milestone Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment