Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] QDialog: Toggling 'maximized' property while hidden still locks scroll #3478

Closed
abruere opened this issue Mar 5, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@abruere
Copy link
Contributor

commented Mar 5, 2019

Thanks for Quasar!

This is a minor issue related to maximized dialog. I’m submitting a PR too.

This is loosely related to #3310.

quasar-v1.0.0-beta.8

Operating System - Linux(4.4.0-142-generic) - linux/x64
NodeJs - 8.11.2

Global packages
NPM - 5.6.0
yarn - 1.12.3
@quasar/cli - 1.0.0-beta.2
cordova - Not installed

Any other software related to your bug:

JsFiddle

Codepen: https://codepen.io/anon/pen/YgGMqe?editors=1010

What did you get as the error?

Toggling maximized on a hidden QDialog locks body scroll.

What were you expecting?

Scroll lock should only apply when QDialog is visible. Maximized can be toggled in background depending on layout or screen size.

What steps did you take, to get the error?

Please have a look at the codepen, where I reproduce using:

  • Screen size based maximized property
  • Manual toggle

abruere added a commit to stelace/quasar that referenced this issue Mar 5, 2019

@nothingismagick

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@abruere

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

Yes I’ve just updated the codepen (forked from components docs) from v1.0.0-beta.7 to v1.0.0-beta.8, thanks.

@rstoenescu rstoenescu closed this in c0f5468 Mar 5, 2019

@rstoenescu

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@abruere Thx for working on a PR! Will be available in beta.9

@abruere

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

Thanks for building Quasar @rstoenescu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.