Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] inconsistency 'outline' & 'outlined' #3498

Closed
mesqueeb opened this Issue Mar 7, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@mesqueeb
Copy link
Contributor

mesqueeb commented Mar 7, 2019

To use an "outline" design we can use a special prop on certain components.

However in V1...

  • the input prop is called outlined
  • while the button prop is called outline

I think it makes more sense if this is both outline or both outlined and made consistent throughout all Quasar.

@nothingismagick

This comment has been minimized.

Copy link
Member

nothingismagick commented Mar 7, 2019

@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Mar 7, 2019

It may seem as inconsistency, but "outlined" is the term Material Design 2 is using for inputs.
We can't make this drastic change on QBtn (& co) and QChip and so on as this would break a lot of people's apps on v1. We need to have a stable API. So probably this should go into v2.

@rstoenescu rstoenescu closed this Mar 7, 2019

@mesqueeb

This comment has been minimized.

Copy link
Contributor Author

mesqueeb commented Mar 7, 2019

Maybe support outlined on q-btn as well and change documentation to that
But while continuing to support outline as well only under the hood

@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Mar 8, 2019

I really want final v1.0.0 build to be fresh and clean, not bloated with different stuff. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.