Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSlider circle marker missing when `label-always` enabled #4002

Closed
2x2xplz opened this issue Apr 30, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@2x2xplz
Copy link
Contributor

commented Apr 30, 2019

This was mentioned on Discord, and it was requested to open a new issue.

When label-always is enabled, the circle marker on the QSlider is not visible "at rest" or while sliding. It appears briefly after letting go of the slider, then it disappears again.

This behavior is viewable in the docs page for QSlider, in the section for "always display label."

(On Chrome/Android, the marker doesn't even show up briefly, in my test.)

Software version

Quasar: 1.0 beta 19
@quasar/app (v1+ only):
OS:
Node:
NPM:
Browsers: Chrome, Firefox on Windows, Chrome on Android
iOS:
Android:
Any other software related to your bug:

JsFiddle

What did you get as the error?

What were you expecting?

What steps did you take, to get the error?

@rstoenescu

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Hi, this is per design and as per Material Guidelines at some point (I see no mention of this in the guidelines at the moment I am writing though).

@rstoenescu rstoenescu closed this Apr 30, 2019

@2x2xplz 2x2xplz referenced this issue Apr 30, 2019

Merged

added a `thumb-always` option (issue #4002) #4008

0 of 10 tasks complete

rstoenescu added a commit that referenced this issue May 1, 2019

added a `thumb-always` option (issue #4002) (#4008)
* added a `thumb-always` option

The default behavior is to hide the slider thumb (the circular marker) whenever a label is present. This can be confusing when the `label-always` option is active, because the thumb is never visible, and it doesn't give the user the expected visual cue that sliding is possible. Even if the user knows, the lack of a thumb makes the visual target (for the mouse, or finger) seem much smaller. Having a `thumb-always` option will keep the thumb visible even with a label, if the developer wants it.

* Update QSlider.json

* Update slider-utils.js
@rstoenescu

This comment has been minimized.

Copy link
Member

commented May 1, 2019

The change will be available in Quasar beta.21. Thanks for doing a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.