Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Bug] QEditor - Toolbar of Qeditor in Edge #4014

Closed
Sambaja opened this issue May 1, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@Sambaja
Copy link

commented May 1, 2019

Software version

@quasar/app (v1+ only): 1.20
OS: Windows 10
Browsers: Edge

JsFiddle

https://codepen.io/anon/pen/qwzRJb?&editable=true&editors=101

What did you get as the error?

The toolbar is reformated when you use the align buttons and the lists (ordered and unordered).

What were you expecting?

Not be reformated.

What steps did you take, to get the error?

To reproduce this you just have to be on edge and click the align buttons or the list ones. This is exclusive to edge. I noticed that the q-editor__toolbar was moved out of the q-editor

before : https://puu.sh/DmsM9/038d17997c.png
after : https://puu.sh/DmsM9/038d17997c.png

@Sambaja Sambaja changed the title [V1] QEditor - Q-editor in Edge [V1][Bug] QEditor - Toolbar of Qeditor in Edge May 1, 2019

@rstoenescu

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Confirmed. Edge browser is erroneously messing with the DOM outside of the content target -- and it shouldn't! Looked for a solution all day but could not find it yet.

@mountash

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Maybe something with closing tags. If model contains <div></div> at the end. All is working.

https://codepen.io/anon/pen/XwrLRE?editors=1010

@mountash

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

@rstoenescu take a look at the ugly hack here 😈

@nothingismagick

This comment has been minimized.

Copy link
Member

commented May 4, 2019

@mountash

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

So, then PR #4047

@rstoenescu rstoenescu closed this in dbe2e53 May 5, 2019

rstoenescu added a commit that referenced this issue May 5, 2019

Merge pull request #4047 from mountash/4014-ie-polyfill-for-justify
fix(QEditor): add ie polyfill for justify (fix: #4014)
@rstoenescu

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Fix will be available in beta.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.