We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug textToRgb() from color utils always returns #ffffff
textToRgb()
#ffffff
Codepen/jsFiddle/Codesandbox (required) https://codesandbox.io/s/codesandbox-app-z1vh5
Expected behavior textToRgb() converts the color string to an appropriate rgb representation.
Platform (please complete the following information): N/A
Additional context It's clearly visible in the source:
const rgb = { r: Math.max(255, parseInt(m[2], 10)), g: Math.max(255, parseInt(m[3], 10)), b: Math.max(255, parseInt(m[4], 10)) }
As all CSS RGB values are always 0-255, this snippet will always return {r: 255, g: 255, b: 255} for any valid CSS color.
{r: 255, g: 255, b: 255}
The text was updated successfully, but these errors were encountered:
fix(quasar): textToRgb incorrect use of Math.max
e018d5a
close quasarframework#4770
e85e0c8
Fix will be available in 1.0.6
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Describe the bug
textToRgb()
from color utils always returns#ffffff
Codepen/jsFiddle/Codesandbox (required)
https://codesandbox.io/s/codesandbox-app-z1vh5
Expected behavior
textToRgb()
converts the color string to an appropriate rgb representation.Platform (please complete the following information):
N/A
Additional context
It's clearly visible in the source:
As all CSS RGB values are always 0-255, this snippet will always return
{r: 255, g: 255, b: 255}
for any valid CSS color.The text was updated successfully, but these errors were encountered: